refactor: renderEvent.GetStatus -> renderEvent.GetOrCreateStatus

Author: egil

src/bunit.core/Rendering/RenderEvent.cs

@@ -30,7 +30,7 @@ public sealed class RenderEvent
 			: (Rendered: false, Changed: false, Disposed: false);
 	}
 
-	internal Status GetStatus(int componentId)
+	internal Status GetOrCreateStatus(int componentId)
 	{
 		if (!statuses.TryGetValue(componentId, out var status))
 		{
@@ -42,25 +42,25 @@ internal Status GetStatus(int componentId)
 
 	internal void SetDisposed(int componentId)
 	{
-		GetStatus(componentId).Disposed = true;
+		GetOrCreateStatus(componentId).Disposed = true;
 	}
 
 	internal void SetUpdated(int componentId, bool hasChanges)
 	{
-		var status = GetStatus(componentId);
+		var status = GetOrCreateStatus(componentId);
 		status.Rendered = true;
 		status.Changed = hasChanges;
 	}
 
 	internal void SetUpdatedApplied(int componentId)
 	{
-		GetStatus(componentId).UpdatesApplied = true;
+		GetOrCreateStatus(componentId).UpdatesApplied = true;
 	}
 
 	internal void AddFrames(int componentId, ArrayRange<RenderTreeFrame> frames)
 	{
 		Frames.Add(componentId, frames);
-		GetStatus(componentId).FramesLoaded = true;
+		GetOrCreateStatus(componentId).FramesLoaded = true;
 	}
 
 	internal record class Status

src/bunit.core/Rendering/TestRenderer.cs

@@ -281,11 +281,9 @@ void PrepareRenderEvent(in RenderBatch renderBatch)
 
 		void LoadChangesIntoRenderEvent(int componentId)
 		{
-			var status = renderEvent.GetStatus(componentId);
+			var status = renderEvent.GetOrCreateStatus(componentId);
 			if (status.FramesLoaded || status.Disposed)
-			{
 				return;
-			}
 
 			var frames = GetCurrentRenderTreeFrames(componentId);
 			renderEvent.AddFrames(componentId, frames);
@@ -300,15 +298,15 @@ void LoadChangesIntoRenderEvent(int componentId)
 					// render tree frames. This can also cause a stack overflow if
 					// the current component was previously a child of the disposed
 					// component (is that possible?)
-					var childStatus = renderEvent.GetStatus(frame.ComponentId);
+					var childStatus = renderEvent.GetOrCreateStatus(frame.ComponentId);
 					if (childStatus.Disposed)
 					{
 						logger.LogDisposedChildInRenderTreeFrame(componentId, frame.ComponentId);
 					}
 					// The assumption is that a component cannot be in multiple places at
 					// once. However, in case this is not a correct assumption, this
 					// ensures that a child components frames are only loaded once.
-					else if (!renderEvent.GetStatus(frame.ComponentId).FramesLoaded)
+					else if (!renderEvent.GetOrCreateStatus(frame.ComponentId).FramesLoaded)
 					{
 						LoadChangesIntoRenderEvent(frame.ComponentId);
 					}
@@ -343,11 +341,7 @@ void InvokeApplyRenderEvent()
 				// CPU cache updates not happening immediately).
 				//
 				// There is no guarantee a caller/test framework has set a sync context.
-				usersSyncContext.Send(static (state) =>
-				{
-					var (renderEvent, renderer) = ((RenderEvent, TestRenderer))state!;
-					renderer.ApplyRenderEvent(renderEvent);
-				}, (renderEvent, this));
+				usersSyncContext.Send(_ => ApplyRenderEvent(renderEvent), null);
 			}
 			else
 			{