Skip to content

Commit d4ff343

Browse files
committed
fix: Better naming for test method (#1048)
* fix: Better naming for test method * fix: Don't use unknown matcher first * fix: Don't use unknown matcher first * Add attribute
1 parent b4813ef commit d4ff343

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

src/bunit.web/Diffing/HtmlComparer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public HtmlComparer()
2121
{
2222
var strategy = new DiffingStrategyPipeline();
2323
strategy.AddDefaultOptions();
24-
strategy.AddMatcher(BlazorDiffingHelpers.UnknownElementMatch, StrategyType.Specialized);
24+
strategy.AddMatcher(BlazorDiffingHelpers.UnknownElementMatch, StrategyType.Generalized);
2525
strategy.AddFilter(BlazorDiffingHelpers.BlazorAttributeFilter, StrategyType.Specialized);
2626
differenceEngine = new HtmlDiffer(strategy);
2727
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
<div class="header">
2+
<div>Custom Metadata Definitions</div>
3+
<zui-button style="color:red"></zui-button>
4+
</div>

tests/bunit.testassets/SampleComponents/CustomElementWithAttribute.razor

Lines changed: 0 additions & 3 deletions
This file was deleted.

tests/bunit.web.tests/Asserting/MarkupMatchesAssertExtensionsTest.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -138,17 +138,17 @@ public void Test015()
138138
path.MarkupMatches("<path />");
139139
}
140140

141-
[Fact(DisplayName = "Werid")]
141+
[Fact(DisplayName = "Handles custom elements with attributes")]
142142
public void Test016()
143143
{
144-
const string expectedMarkup = @"<div class=""main"">
145-
<my-button emphasis=""primary-highlight"" disabled>Add new<my-icon slot=""icon"" size=""s32""></my-icon></my-button>
146-
</div>
147-
";
144+
const string expectedMarkup = @"
145+
<div class=""header"">
146+
<div>Custom Metadata Definitions</div>
147+
<zui-button diff:ignoreAttributes></zui-button>
148+
</div>";
148149

149-
// Act
150-
var chart = RenderComponent<CustomElementWithAttribute>();
150+
var cut = RenderComponent<CustomElement>();
151151

152-
chart.MarkupMatches(expectedMarkup);
152+
cut.MarkupMatches(expectedMarkup);
153153
}
154-
}
154+
}

0 commit comments

Comments
 (0)