-
-
Notifications
You must be signed in to change notification settings - Fork 209
Externalize acorn-to-esprima? #24
Comments
Sure, the only thing I see being useful is the token conversion and that's only a handful of lines though. The actual AST transformation code completely destroys the AST and just turns nodes that ESLint doesn't like into nodes that it'll happily digest. |
Yeah sounds good - then wouldn't have to copy/paste similar changes between this and If we do this we could move to a more extensive test suite then we have now? It would be cool to be able to run esprima/acorn's tests and check if the ASTs are the same see how close we can get? Not sure how that would work, I suppose with a git submodule? It would be similar to #62 I think - running all of ESLint's tests with |
Made the repo - https://github.com/babel/acorn-to-esprima. Will be moving it over later |
@nzakas took a long time but I released https://github.com/babel/acorn-to-esprima. And probably need to be changed for other projects to use it better. |
Thanks, I'll take a look. |
Would you be open to publishing acorn-to-esprima as it's own package? I had something like this half done and would love to just drop it and use what you have. I think it would be useful for a number of tools that would like to support both acorn and esprima.
The text was updated successfully, but these errors were encountered: