Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with syntax highlighting for arrow functions in ES6 class declarations #301

Closed
huntwj opened this issue Jan 18, 2017 · 5 comments
Closed

Comments

@huntwj
Copy link

huntwj commented Jan 18, 2017

The first arrow function in ES6 class declarations does not highlight correctly.

Example 1:
screen shot 2017-01-18 at 2 06 28 pm

Example 2:
screen shot 2017-01-18 at 2 05 36 pm

@borela
Copy link

borela commented Jan 15, 2018

Try https://github.com/borela/naomi it even supports stage-0 features.

@jbccollins
Copy link

@borela that's pretty sweet! It does have some pretty annoying issues though. I find borela/naomi#72 to be particularly annoying and even with the manual patch described in those comments it still balks on nested objects in some cases.

@borela
Copy link

borela commented Feb 27, 2018

@jbccollins I actually prefer keys being highlighted as unquoted strings too, I am thinking about reverting back to unquoted strings and see how many users will complain about it before I implement a configurable system.

@borela
Copy link

borela commented Feb 28, 2018

@jbccollins Try version >= 3.7.0

@Thom1729
Copy link
Contributor

This should be fixed in v10.0.0-beta.1. See #379 for more information on the new release. Please report any problems with v10 in a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants