Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark run error #309

Closed
boopathi opened this issue Dec 1, 2016 · 5 comments
Closed

Benchmark run error #309

boopathi opened this issue Dec 1, 2016 · 5 comments

Comments

@boopathi
Copy link
Member

boopathi commented Dec 1, 2016

Reported by @shinew in #286 (comment)

I tried running the benchmark (./scripts/benchmark.js react@0.14.3 react/dist/react.js), but I got an error (below). This was on master.

/Users/shinew/dev/babili/node_modules/babel-core/lib/transformation/file/index.js:600
      throw err;
      ^

TypeError: unknown: Property right of AssignmentExpression expected node to be of a type ["Expression"] but instead got undefined
    at Object.validate (/Users/shinew/dev/babili/node_modules/babel-types/lib/definitions/index.js:109:13)
    at validate (/Users/shinew/dev/babili/node_modules/babel-types/lib/index.js:511:9)
    at Object.builder (/Users/shinew/dev/babili/node_modules/babel-types/lib/index.js:472:7)
    **at liftDeclaration (/Users/shinew/dev/babili/packages/babel-plugin-transform-merge-sibling-variables/lib/index.js:31:29)**
    at PluginPass.ForStatement (/Users/shinew/dev/babili/packages/babel-plugin-transform-merge-sibling-variables/lib/index.js:44:9)
    at newFn (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/visitors.js:276:21)
    at NodePath._call (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:76:18)
    at NodePath.call (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:48:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:105:12)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitMultiple (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:103:17)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:190:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitSingle (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:108:19)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:192:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitMultiple (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:103:17)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:190:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitSingle (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:108:19)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:192:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitMultiple (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:103:17)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:190:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitSingle (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:108:19)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:192:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitMultiple (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:103:17)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:190:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitMultiple (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:103:17)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:190:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitSingle (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:108:19)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:192:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitSingle (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:108:19)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:192:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitMultiple (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:103:17)
    at TraversalContext.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/context.js:190:19)
    at Function.traverse.node (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/shinew/dev/babili/node_modules/babel-traverse/lib/path/context.js:115:19)

/cc @vigneshshanmugam
@vigneshshanmugam
Copy link
Member

@boopathi will take a look..

@vigneshshanmugam
Copy link
Member

vigneshshanmugam commented Dec 1, 2016 •
edited
Loading

I tried it on latest master and with node 6.5.0.. I am actually getting the result.

/cc @kangax

@vigneshshanmugam
Copy link
Member

vigneshshanmugam commented Dec 1, 2016 •
edited
Loading

may be an issue in old babel-core ? babel/babel#2860

I am running 6.18.0 and seeing no issues.

@shinew - can you verify?

@shinew
Copy link
Contributor

shinew commented Dec 1, 2016

Error still here. Running OSX 10.12.1, node v6.8.1.

Steps to repro:

git clone https://github.com/babel/babili.git
cd babili
npm install
npm run bootstrap
npm run build
./scripts/benchmark.js react@0.14.3 react/dist/react.js

Let me know if you need any other info. It'd be helpful if someone else can verify the above steps lead to the error.

@vigneshshanmugam
Copy link
Member

@shinew Thanks.. I can able to reproduce now. found the bug in the code. Will create a PR soon.

vigneshshanmugam added a commit to vigneshshanmugam/babili that referenced this issue Dec 1, 2016
@vigneshshanmugam
dont lift declarations when not intialized (fix babel#309)
acee101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boopathi @shinew @vigneshshanmugam