Don't use path.replaceWith() with a source string, use path.replaceWithSourceString() #576

INRIX-Xiaodi-Huang · 2017-06-13T18:12:41Z

ERROR in unknown: Don't use path.replaceWith() with a source string, use path.replaceWithSourceString()

Seems to be the result of this change :
https://github.com/babel/babili/pull/543/files

The text was updated successfully, but these errors were encountered:

boopathi · 2017-06-13T20:35:45Z

Thanks. Do you have a small snippet as input to reproduce this ?

INRIX-Xiaodi-Huang · 2017-06-13T22:35:46Z

Our codebase is pretty large. I am not sure what caused this error when minifying. I was using the babili webpack plugin with the following options.

(isProdFlavor = true);

new BabiliPlugin({
  booleans: isProdFlavor,
  builtIns: isProdFlavor,
  consecutiveAdds: isProdFlavor,
  flipComparisons: isProdFlavor,
  infinity: isProdFlavor,
   mangle: isProdFlavor,
   memberExpressions: isProdFlavor,
  mergeVars: isProdFlavor,
  numericLiterals: isProdFlavor,
  propertyLiterals: isProdFlavor,
  regexpConstructors: false,
  removeUndefined: isProdFlavor,
  replace: isProdFlavor,
   simplify: isProdFlavor,
  simplifyComparisons: isProdFlavor,
   typeConstructors: isProdFlavor,
  undefinedToVoid: isProdFlavor
 })

MDendura · 2017-06-14T09:11:17Z

@INRIX-Xiaodi-Huang I've had the same error when updating babili-webpack-plugin from 0.0.11 to 0.1.1. Are you using that too?

arthurmchr · 2017-06-14T10:18:48Z

Using babili version 0.1.3 I got the error

boopathi · 2017-06-14T10:41:59Z

Can you share the stack trace ?

arthurmchr · 2017-06-14T10:56:38Z

Error: /Users/arthur/Documents/jean/gabrielle.js: Don't use `path.replaceWith()` with a source string, use `path.replaceWithSourceString()`
    at NodePath.replaceWith (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/path/replacement.js:139:11)
    at swap (/Users/arthur/Documents/jean/node_modules/babel-plugin-minify-constant-folding/lib/index.js:42:10)
    at PluginPass.CallExpression (/Users/arthur/Documents/jean/node_modules/babel-plugin-minify-constant-folding/lib/index.js:171:16)
    at newFn (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/visitors.js:276:21)
    at NodePath._call (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/path/context.js:76:18)
    at NodePath.call (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/path/context.js:48:17)
    at NodePath.visit (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/path/context.js:105:12)
    at TraversalContext.visitQueue (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitSingle (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/context.js:108:19)
    at TraversalContext.visit (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/context.js:192:19)
    at Function.traverse.node (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/index.js:114:17)

damianobarbati · 2017-06-14T13:14:59Z

same here! +1

boopathi · 2017-06-14T14:35:41Z

/cc @j-f1 Do you know why this happens in the swap function ?

https://github.com/babel/babili/blob/7e2b315e37fc6392dbe05acf9463520d05434f56/packages/babel-plugin-minify-constant-folding/src/index.js#L34

j-f1 · 2017-06-14T15:39:42Z

@boopathi I have no idea. It appears that all of the methods used return nodes. Can anyone provide an example snippet that fails?

michaeltrim · 2017-06-15T20:48:32Z

+1

j-f1 · 2017-06-15T21:44:24Z

@michaeltrim Can you provide an example code snippet that fails?

johnryan · 2017-06-15T22:20:27Z

@j-f1 Any suggestions for how to figure out what line of code is failing? There's not much in the stack trace so finding the failing chunk of code seems pretty impossible in a large project.

damianobarbati · 2017-06-15T22:21:27Z

guys I have no way to provide snippets for the fail :(

michaeltrim · 2017-06-16T09:02:17Z

Not sure how to provide a code snippet that fails.

I get the Error:

ERROR in unknown: Don't use path.replaceWith() with a source string, use path.replaceWithSourceString()

when I run yarn run build-main and do a stack trace before the error is thrown I get the following, not sure if that helps:

at NodePath.replaceWith (/myapp/node_modules/babel-traverse/lib/path/replacement.js:140:13)
at swap (/myapp/node_modules/babel-plugin-minify-constant-folding/lib/index.js:42:10)
at PluginPass.CallExpression (/myapp/node_modules/babel-plugin-minify-constant-folding/lib/index.js:171:16)
at newFn (/myapp/node_modules/babel-traverse/lib/visitors.js:276:21)
at NodePath._call (/myapp/node_modules/babel-traverse/lib/path/context.js:76:18)
at NodePath.call (/myapp/node_modules/babel-traverse/lib/path/context.js:48:17)
at NodePath.visit (/myapp/node_modules/babel-traverse/lib/path/context.js:105:12)
at TraversalContext.visitQueue (/myapp/node_modules/babel-traverse/lib/context.js:150:16)
at TraversalContext.visitSingle (/myapp/node_modules/babel-traverse/lib/context.js:108:19)
at TraversalContext.visit (/myapp/node_modules/babel-traverse/lib/context.js:192:19)
at Function.traverse.node (/myapp/node_modules/babel-traverse/lib/index.js:114:17)
at NodePath.visit (/myapp/node_modules/babel-traverse/lib/path/context.js:115:19)
at TraversalContext.visitQueue (/myapp/node_modules/babel-traverse/lib/context.js:150:16)
at TraversalContext.visitSingle (/myapp/node_modules/babel-traverse/lib/context.js:108:19)
at TraversalContext.visit (/myapp/node_modules/babel-traverse/lib/context.js:192:19)
at Function.traverse.node (/myapp/node_modules/babel-traverse/lib/index.js:114:17)
at NodePath.visit (/myapp/node_modules/babel-traverse/lib/path/context.js:115:19)
at TraversalContext.visitQueue (/myapp/node_modules/babel-traverse/lib/context.js:150:16)
at TraversalContext.visitMultiple (/myapp/node_modules/babel-traverse/lib/context.js:103:17)
at TraversalContext.visit (/myapp/node_modules/babel-traverse/lib/context.js:190:19)
at Function.traverse.node (/myapp/node_modules/babel-traverse/lib/index.js:114:17)
at NodePath.visit (/myapp/node_modules/babel-traverse/lib/path/context.js:115:19)
at TraversalContext.visitQueue (/myapp/node_modules/babel-traverse/lib/context.js:150:16)
at TraversalContext.visitSingle (/myapp/node_modules/babel-traverse/lib/context.js:108:19)
at TraversalContext.visit (/myapp/node_modules/babel-traverse/lib/context.js:192:19)
at Function.traverse.node (/myapp/node_modules/babel-traverse/lib/index.js:114:17)
at NodePath.visit (/myapp/node_modules/babel-traverse/lib/path/context.js:115:19)
at TraversalContext.visitQueue (/myapp/node_modules/babel-traverse/lib/context.js:150:16)
at TraversalContext.visitMultiple (/myapp/node_modules/babel-traverse/lib/context.js:103:17)
at TraversalContext.visit (/myapp/node_modules/babel-traverse/lib/context.js:190:19)
at Function.traverse.node (/myapp/node_modules/babel-traverse/lib/index.js:114:17)

michaeltrim · 2017-06-16T09:15:24Z

I can see that the method path.replaceWith() is getting passed a string of "[object Object]"

People were calling `"foo".toString() or ["foo", "bar"].toString()`, which returned the real JS string `"[object Object]"`, the stringified version of the replacements object.

j-f1 · 2017-06-16T10:12:13Z

@michaeltrim Can you try replacing node_modules/babel-plugin-minify-constant-folding/lib/index.js with this patched version to see if that fixes it?

michaeltrim · 2017-06-16T11:56:25Z

@j-f1 That has fixed the error when running yarn run build-main, thank you.

yarn run package still doesn't complete but this may be unrelated just doing some investigation and will let you know.

michaeltrim · 2017-06-16T13:39:29Z

@j-f1 So the build does eventually work but I'm getting an out of memory error in the source map generator, not sure if this is connected but it didn't occur before

]
[1] <--- Last few GCs --->
[1]
[1] [1887:0x102801600] 428064 ms: Mark-sweep 1398.8 (1570.2) -> 1398.8 (1570.2) MB, 2901.9 / 0.0 ms allocation failure GC in old space requested
[1] [1887:0x102801600] 431103 ms: Mark-sweep 1398.8 (1570.2) -> 1398.6 (1539.2) MB, 3038.7 / 0.0 ms last resort
[1] [1887:0x102801600] 434050 ms: Mark-sweep 1398.6 (1539.2) -> 1398.6 (1539.2) MB, 2946.1 / 0.0 ms last resort
[1]
[1]
[1] <--- JS stacktrace --->
[1]
[1] ==== JS stack trace =========================================
[1]
[1] Security context: 0x1781caa29891
[1] 2: addMapping(aka SourceMapGenerator_addMapping) [/myapp/node_modules/babel-generator/node_modules/source-map/lib/source-map-generator.js:~94] [pc=0x3c00c07f75d0](this=0x3b3ccc65e509 <a SourceMapGenerator with map 0x3e8f0d3f4da1>,aArgs=0x30deb9bd3279 <an Object with map 0x3e8f0d3fa289>)
[1] 3: arguments adaptor frame: 3->1
[1] 4: InnerArrayForEa...
[1]
[1] FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
[1] 1:
[1] node::Abort() [/Users/michaeltrim/.nvm/versions/node/v8.1.2/bin/node]
[1] 2: node::FatalException(v8::Isolate*, v8::Localv8::Value, v8::Localv8::Message) [/Users/michaeltrim/.nvm/versions/node/v8.1.2/bin/node]
[1] 3: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [/Users/michaeltrim/.nvm/versions/node/v8.1.2/bin/node]
[1] 4: v8::internal::Factory::NewUninitializedFixedArray(int) [/Users/michaeltrim/.nvm/versions/node/v8.1.2/bin/node]
[1] 5:
[1] v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastPackedObjectElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)2> >::GrowCapacity(v8::internal::Handlev8::internal::JSObject, unsigned int) [/Users/michaeltrim/.nvm/versions/node/v8.1.2/bin/node]
[1] 6:
[1] v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [/Users/michaeltrim/.nvm/versions/node/v8.1.2/bin/node]
[1] 7: 0x3c00bf40437d
[1] npm run build-rendere

michaeltrim · 2017-06-16T15:28:29Z

Believe memory issue related to #332

frzi · 2017-06-16T16:10:32Z

@j-f1 This patch fixed the issue for me as well. Thanks!

damianobarbati · 2017-06-16T16:55:43Z

@j-f1 is a patch about to be release soon?

j-f1 · 2017-06-16T16:58:25Z

I was just checking to see if that fixed the problem. The PR above includes that fix.

* Should fix #576 People were calling `"foo".toString() or ["foo", "bar"].toString()`, which returned the real JS string `"[object Object]"`, the stringified version of the replacements object. * Prettier code means prettier green checkmarks * Testing testing 123 * Forgot the parens around the object literal * Semicolons! * npm run format

Xazzzi-CT · 2017-06-19T16:06:30Z

Is this on npm yet? Asking because i still get this error message.

MikeLP · 2017-06-19T16:53:51Z

It's really urgent.

ahumphreys87 · 2017-06-19T16:56:54Z

I've downgraded to 0.0.11 while waiting. If it's breaking production builds then you could do the same. I think they said it would be released this afternoon. If downgrading is too much trouble

…

On Mon, 19 Jun 2017 at 17:53 Yan Zhabin ***@***.***> wrote: It's really urgent. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#576 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACZOuC1MLhDyJN2KYoUMjrl_CWsA_3eZks5sFqeigaJpZM4N43b0> .

damianobarbati · 2017-06-20T07:47:55Z

Just tried the 0.1.1 and it's broken as well 😱

ahumphreys87 · 2017-06-20T07:53:12Z

0.0.11

…

On Tue, 20 Jun 2017 at 08:47 damiano.barbati ***@***.***> wrote: Just tried the 0.1.1 and it's broken as well 😱 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#576 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACZOuCoAIe9kCjYj5pI7dMfi3ArDA63bks5sF3ksgaJpZM4N43b0> .

damianobarbati · 2017-06-20T07:56:05Z

@ahumphreys87 yep, using that for now thanks!

ahumphreys87 · 2017-06-20T07:57:43Z

Awesome, fingers crossed the fix version won't be long

…

On Tue, 20 Jun 2017 at 08:56 damiano.barbati ***@***.***> wrote: @ahumphreys87 <https://github.com/ahumphreys87> yep, using that for now thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#576 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACZOuHzVhlXtNe8VBbMX3-0JgZNhO0xiks5sF3sXgaJpZM4N43b0> .

vigneshshanmugam · 2017-06-20T20:14:33Z

New version is released now with this fix https://github.com/babel/babili/releases/tag/babili%400.1.4

LeeeeeeM · 2018-11-02T02:34:50Z

problems with babel-traverse...em...

boopathi added the bug Confirmed bug label Jun 13, 2017

Osmose mentioned this issue Jun 14, 2017

Traceback: Don't use path.replaceWith() with a source string mozilla/normandy#812

Closed

boopathi changed the title ~~New error in latest version...~~ Don't use path.replaceWith() with a source string, use path.replaceWithSourceString() Jun 14, 2017

j-f1 added a commit to j-f1/forked-babili that referenced this issue Jun 16, 2017

Should fix babel#576

d8c30c2

People were calling `"foo".toString() or ["foo", "bar"].toString()`, which returned the real JS string `"[object Object]"`, the stringified version of the replacements object.

j-f1 mentioned this issue Jun 16, 2017

Fix #576 #587

Merged

vigneshshanmugam closed this as completed in #587 Jun 19, 2017

vigneshshanmugam mentioned this issue Jun 20, 2017

babel-plugin-minify-constant-folding v0.1.2 #584

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't use path.replaceWith() with a source string, use path.replaceWithSourceString() #576

Don't use path.replaceWith() with a source string, use path.replaceWithSourceString() #576

INRIX-Xiaodi-Huang commented Jun 13, 2017

boopathi commented Jun 13, 2017

INRIX-Xiaodi-Huang commented Jun 13, 2017 •

edited

Loading

MDendura commented Jun 14, 2017

arthurmchr commented Jun 14, 2017 •

edited

Loading

boopathi commented Jun 14, 2017

arthurmchr commented Jun 14, 2017

damianobarbati commented Jun 14, 2017

boopathi commented Jun 14, 2017

j-f1 commented Jun 14, 2017

michaeltrim commented Jun 15, 2017

j-f1 commented Jun 15, 2017

johnryan commented Jun 15, 2017

damianobarbati commented Jun 15, 2017

michaeltrim commented Jun 16, 2017 •

edited

Loading

michaeltrim commented Jun 16, 2017

j-f1 commented Jun 16, 2017

michaeltrim commented Jun 16, 2017

michaeltrim commented Jun 16, 2017

michaeltrim commented Jun 16, 2017

frzi commented Jun 16, 2017

damianobarbati commented Jun 16, 2017

j-f1 commented Jun 16, 2017

Xazzzi-CT commented Jun 19, 2017

MikeLP commented Jun 19, 2017

ahumphreys87 commented Jun 19, 2017 via email

damianobarbati commented Jun 20, 2017

ahumphreys87 commented Jun 20, 2017 via email

damianobarbati commented Jun 20, 2017

ahumphreys87 commented Jun 20, 2017 via email

vigneshshanmugam commented Jun 20, 2017

LeeeeeeM commented Nov 2, 2018

Don't use path.replaceWith() with a source string, use path.replaceWithSourceString() #576

Don't use path.replaceWith() with a source string, use path.replaceWithSourceString() #576

Comments

INRIX-Xiaodi-Huang commented Jun 13, 2017

boopathi commented Jun 13, 2017

INRIX-Xiaodi-Huang commented Jun 13, 2017 • edited Loading

MDendura commented Jun 14, 2017

arthurmchr commented Jun 14, 2017 • edited Loading

boopathi commented Jun 14, 2017

arthurmchr commented Jun 14, 2017

damianobarbati commented Jun 14, 2017

boopathi commented Jun 14, 2017

j-f1 commented Jun 14, 2017

michaeltrim commented Jun 15, 2017

j-f1 commented Jun 15, 2017

johnryan commented Jun 15, 2017

damianobarbati commented Jun 15, 2017

michaeltrim commented Jun 16, 2017 • edited Loading

michaeltrim commented Jun 16, 2017

j-f1 commented Jun 16, 2017

michaeltrim commented Jun 16, 2017

michaeltrim commented Jun 16, 2017

michaeltrim commented Jun 16, 2017

frzi commented Jun 16, 2017

damianobarbati commented Jun 16, 2017

j-f1 commented Jun 16, 2017

Xazzzi-CT commented Jun 19, 2017

MikeLP commented Jun 19, 2017

ahumphreys87 commented Jun 19, 2017 via email

damianobarbati commented Jun 20, 2017

ahumphreys87 commented Jun 20, 2017 via email

damianobarbati commented Jun 20, 2017

ahumphreys87 commented Jun 20, 2017 via email

vigneshshanmugam commented Jun 20, 2017

LeeeeeeM commented Nov 2, 2018

INRIX-Xiaodi-Huang commented Jun 13, 2017 •

edited

Loading

arthurmchr commented Jun 14, 2017 •

edited

Loading

michaeltrim commented Jun 16, 2017 •

edited

Loading