support for for..of/for..await in DCE #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
boopathi
commented
Oct 22, 2016
boopathi
commented
- (Close for..of throws #207)
for..of and for..await loops are not considered in DCE and unused var declarations in these loops are removed and this results in an empty LVal. The same exception which is considered for a for..in loop is also applied for for..of or for..await loops, and we use an Alias that Babel provides - ForXStatement which is a for..in, for..of, or a for..await loop. + (Close #207)
boopathi
changed the title
hzoo
reviewed
Oct 22, 2016
| }); | ||
|
|
||
| // TODO: enable. (still a non standard feature) | ||
| xit("should not remove var from for..await statements", () => { |
There was a problem hiding this comment.
Can do transform(source) -> transform(source, { parserOpts: { plugins: ['asyncGenerators'] } }) to remove xit?
There was a problem hiding this comment.
I thought we will add this after it landed in stage-4 ... but sure ... why not !
hzoo
approved these changes
Oct 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.