🚀 Prettier #478
Merged
🚀 Prettier #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 82.25% 82.38% +0.13%
==========================================
Files 35 35
Lines 2462 2611 +149
Branches 808 923 +115
==========================================
+ Hits 2025 2151 +126
- Misses 257 280 +23
Partials 180 180
Continue to review full report at Codecov.
|
| if (path.isVariableDeclarator() && path.parent.declarations[0] === path.node && | ||
| path.parent.declarations.length === 1 | ||
| if ( | ||
| path.isVariableDeclarator() && path.parent.declarations[0] === path.node && path.parent.declarations.length === 1 |
There was a problem hiding this comment.
maybe reduce the print width around 80-100?
| @@ -25,7 +25,7 @@ describe("type-constructors-plugin", () => { | |||
|
|
|||
| it("should turn String(x) to x + ''", () => { | |||
| const source = "String(x);"; | |||
| const expected = "x + \"\";"; | |||
| const expected = 'x + "";'; | |||
| @@ -14,7 +14,7 @@ describe("node-env-inline-plugin", () => { | |||
| const prev = process.env.NODE_ENV; | |||
| process.env.NODE_ENV = "development"; | |||
|
|
|||
| const source = "process.env.NODE_ENV === \"development\";"; | |||
| const source = 'process.env.NODE_ENV === "development";'; | |||
There was a problem hiding this comment.
single quotes instead of double
There was a problem hiding this comment.
JSON is double quotes. So I think prettier chooses single outside double instead of the other way around.
boopathi
added
the
Tag: Internal
|
@boopathi width 80 looks much better.. |
vigneshshanmugam
approved these changes
Mar 17, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review two commits individually.
First one adds prettier and changes eslint configs
Second one simply applies prettier