Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contributing.md [skip ci] #480

Merged
merged 3 commits into from
Mar 17, 2017
Merged

Update Contributing.md [skip ci] #480

merged 3 commits into from
Mar 17, 2017

Conversation

boopathi
Copy link
Member

No description provided.

@boopathi boopathi added the Tag: Docs Pull Request updating Documentation label Mar 17, 2017
existentialism
existentialism reviewed Mar 17, 2017
View reviewed changes
CONTRIBUTING.md Outdated
```

to build Babel **once** or:
to build **once**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move these labels above the command?

To build once:

npm run build

Or to do an incremental build in watch mode:

npm run watch

CONTRIBUTING.md Outdated
To run all tests:
#### Lint

The project uses [prettier](https://github.com/prettier/prettier) for formatting code and [eslint](https://github.com/eslint/eslint) for other linting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, maybe:

This project uses prettier for formatting code and eslint for other linting.

To check both:

npm run lint

You can also run them each individually:

# prettier
npm run format-check

# eslint
npm run eslint

@boopathi boopathi merged commit 2379fc1 into master Mar 17, 2017
@boopathi boopathi deleted the contrib-4 branch March 17, 2017 22:46
@renovate renovate bot mentioned this pull request Feb 7, 2020
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@existentialism existentialism existentialism left review comments

Assignees
No one assigned
Labels
Tag: Docs Pull Request updating Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boopathi @existentialism