Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashing in simplify plugin. Deopt instead #517

Merged
merged 1 commit into from
May 4, 2017
Merged

Fix crashing in simplify plugin. Deopt instead #517

merged 1 commit into from
May 4, 2017

Conversation

boopathi
Copy link
Member

@boopathi boopathi commented May 4, 2017

@codecov
Copy link

codecov bot commented May 4, 2017 •
edited
Loading

Codecov Report

Merging #517 into master will decrease coverage by 0.05%.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #517      +/-   ##
========================================
- Coverage   83.06%    83%   -0.06%     
========================================
  Files          34     34              
  Lines        2521   2524       +3     
  Branches      896    897       +1     
========================================
+ Hits         2094   2095       +1     
- Misses        255    256       +1     
- Partials      172    173       +1
Impacted Files Coverage Δ
packages/babel-plugin-minify-simplify/src/index.js 80.62% <25%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369d05e...b130a38. Read the comment docs.

vigneshshanmugam
vigneshshanmugam reviewed May 4, 2017
View reviewed changes
packages/babel-plugin-minify-simplify/__tests__/simplify-test.js
let thingB = param.b;
if (thingA || thingB) {
let thingC = param.c;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation is screwed up here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. Has happened before for if_return.

@boopathi boopathi merged commit 713fb8f into master May 4, 2017
@boopathi boopathi deleted the simplify-scope-1 branch May 4, 2017 20:28
@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label May 4, 2017
@bmeurant bmeurant mentioned this pull request May 23, 2017
Closed
@renovate renovate bot mentioned this pull request Feb 7, 2020
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees
No one assigned
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boopathi @vigneshshanmugam