-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix removal of quotes from property names #543
Conversation
boopathi
commented
May 22, 2017
•
edited
Loading
edited
- Fix don't try and minify props that contain unicode #416
- Fix Only allow safe identifiers as object keys (Fixes #416) #445
- Fix Syntax errors after minifying unicode #415
@mathiasbynens Would like you to review this. There are a few more corner cases missing I suppose - for example - |
Or would it suffice to only transform valid Identifiers ( |
There’s no |
@mathiasbynens Are you thinking of something like this? https://github.com/shapesecurity/shift-codegen-js/blob/0d09bd8a881c62c1bb85d6ff3cfa09697867ed0a/src/minimal-codegen.js#L636-L643 |
@michaelficarra Exactly! |
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
==========================================
- Coverage 83.39% 82.86% -0.53%
==========================================
Files 42 44 +2
Lines 2860 2900 +40
Branches 1003 1012 +9
==========================================
+ Hits 2385 2403 +18
- Misses 284 303 +19
- Partials 191 194 +3
Continue to review full report at Codecov.
|
@michaelficarra Thanks a lot. I used the code from that repository and have also added the license. Please review the changes. |