Remove folding Array.prototype.concat (fix #577) #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @j-f1 |
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
+ Coverage 82.86% 83.02% +0.16%
==========================================
Files 44 44
Lines 2900 2928 +28
Branches 1012 1022 +10
==========================================
+ Hits 2403 2431 +28
Misses 303 303
Partials 194 194
Continue to review full report at Codecov.
|
j-f1
suggested changes
Jun 14, 2017
| @@ -107,9 +107,6 @@ describe("constant-folding-plugin", () => { | |||
| it("should handle Array methods on array literals", () => { | |||
| const source = unpad( | |||
| ` | |||
| [1, 2, 3].concat([4, 5, 6]); | |||
| [a, b, c].concat([d, e], f, g, [h]); | |||
| [1, 2, 3]["concat"]([4, 5, 6]); | |||
There was a problem hiding this comment.
You might want to test this with push since you’re removing it:
[1, 2, 3]["push"]([4, 5, 6])| return t.arrayExpression( | ||
| this.elements.concat( | ||
| ...args.map(arg => { | ||
| if (t.isArrayExpression(arg)) return arg.elements; |
There was a problem hiding this comment.
Would it be possible to check if any of these are variables instead of removing this entirely? For example, [a, b, c].concat([1, 2, 3]) is safe.
There was a problem hiding this comment.
Is it really common to use constants here in concat ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.