You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interesting that it didn't happen for a - mangler replaces the identifier and will create a new identifier and this one won't have the type information.
Just curious - why would you want a type annotation for minified code - don't we assume the output is JavaScript? If we do some unsafe transformations, types are going to mismatch somewhere and flow is going to throw an error on the transformed code.
I stumbled at this when running a smoke test (on Babel repo, actually). It was erroring out without 'syntax-flow' plugin so once I added that I noticed this inconsistency in output. So this is purely theoretical at this point but still shows that something is off.
With #390, all bindings should get flow removed, as we were doing previously binding.identifier.name = newName. Now we replace the identifier using path. So flow annotation should be removed.
gives me this:
Shouldn't this be:
/cc @boopathi
The text was updated successfully, but these errors were encountered: