We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I've been testing how Babili works with CKEditor 5 and I encountered a bug with swapped variable names.
I tried to debug it and the smallest possible scenario is minifying this function: https://github.com/ckeditor/ckeditor5-utils/blob/d3702f4d396849ab3e67358ef74fb670133b4e89/src/dom/position.js#L78-L113
If you pass it through Babili (see on REPL) the name property in the return value is set to bestPosition from line 93.
name
bestPosition
We had this:
[ name, bestPosition ] = getBestPosition( positions, targetRect, elementRect, limiterRect, viewportRect ) // ... return { left, top, name };
And we get this:
[i,j]=getBestPosition(c,h,g,m,n) // ... return{left:k,top:l,name:j}
The text was updated successfully, but these errors were encountered:
Fun fact, if you swap order of variable definitions to:
let name; let bestPosition;
everything is ok.
Sorry, something went wrong.
Related #326, #369. #390 fixes it and is already merged to master.
No branches or pull requests
I've been testing how Babili works with CKEditor 5 and I encountered a bug with swapped variable names.
I tried to debug it and the smallest possible scenario is minifying this function: https://github.com/ckeditor/ckeditor5-utils/blob/d3702f4d396849ab3e67358ef74fb670133b4e89/src/dom/position.js#L78-L113
If you pass it through Babili (see on REPL) the
name
property in the return value is set tobestPosition
from line 93.We had this:
And we get this:
The text was updated successfully, but these errors were encountered: