Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated Benchmark URLs #816

Closed
RetroCraft opened this issue Apr 3, 2018 · 3 comments · Fixed by #817
Closed

Outdated Benchmark URLs #816

RetroCraft opened this issue Apr 3, 2018 · 3 comments · Fixed by #817
Labels
good first issue A newcomer friendly topic to work on.

Comments

@RetroCraft
Copy link

The benchmarking script scripts/benchmark.js points to https://unpkg.com/react/dist/react.js as a benchmark, but the React team no longer provides a dist/react.js file. This causes an error when trying to run benchmarks.

To reproduce:

$ git clone --depth 1 https://github.com/babel/minify.git
$ cd minify
$ yarn install
$ npm run bootstrap
$ npm run build
$ ./scripts/benchmark.js

Error log here.
@vigneshshanmugam vigneshshanmugam added the good first issue A newcomer friendly topic to work on. label Apr 3, 2018
@vigneshshanmugam
Copy link
Member

Thanks for the report. Do you wanna open a PR?

@ganes1410
Copy link
Contributor

@vigneshshanmugam can i take this?

@vigneshshanmugam
Copy link
Member

Yes please go ahead 👍

@ganes1410 ganes1410 mentioned this issue Apr 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A newcomer friendly topic to work on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update outdated react url
3 participants
@vigneshshanmugam @RetroCraft @ganes1410