You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
which is wrong - the call to bar() can have side effects.
I expect the bug is here: this code assumes that anything which .evaluate()s confidently can be safely replaced with its evaluation, but that's not true - you can have side effects even for things you're confident about. Compare the more complex code in the path for IfStatement, which was added in #386 to fix #385. I imagine the fix is basically copying that code to the ConditionalExpression case; probably a good first issue for someone.
(This issue is pretty much the same as #385 (comment), just with slightly different input conditions.)
The text was updated successfully, but these errors were encountered:
Copying from #930 (comment) to make sure it gets tracked:
with dead code and simplify gets transformed to
which is wrong - the call to
bar()
can have side effects.I expect the bug is here: this code assumes that anything which
.evaluate()
s confidently can be safely replaced with its evaluation, but that's not true - you can have side effects even for things you're confident about. Compare the more complex code in the path forIfStatement
, which was added in #386 to fix #385. I imagine the fix is basically copying that code to theConditionalExpression
case; probably a good first issue for someone.(This issue is pretty much the same as #385 (comment), just with slightly different input conditions.)
The text was updated successfully, but these errors were encountered: