chore: upgrade multibuild #113
Conversation
…as BABYLON_BUILD_OPTIONS=testnet
RafilxTenfen
requested review from
gitferry,
samricotta,
KonradStaniec and
a team
and removed request for
a team
There was a problem hiding this comment.
At the moment, data files from the mainnet and testnet are the same but just to simulate/test, when we get close to launch, the testnet and mainnet will have different data files
|
|
||
| func TestHardCodedBtcStakingParamsAreValid(t *testing.T) { | ||
| bbnApp := app.NewTmpBabylonApp() | ||
| for _, upgradeData := range UpgradeV1Data { |
There was a problem hiding this comment.
each unit test now check both testnet and mainnet data files
| AddressReceiver string `json:"address_receiver"` | ||
| Amount int64 `json:"amount"` | ||
| } `json:"token_distribution"` | ||
| func CreateUpgrade(upgradeDataStr UpgradeDataString) upgrades.Upgrade { |
There was a problem hiding this comment.
avoid having a var for each upgrade, by accepting the upgrade data as parameter
| @@ -9,7 +9,7 @@ babylond: babylond-rmi | |||
|
|
|||
| babylond-e2e: | |||
| docker build --tag babylonlabs-io/babylond -f babylond/Dockerfile ${BABYLON_FULL_PATH} \ | |||
| --build-arg BUILD_TAGS="e2e" | |||
| --build-arg BABYLON_BUILD_OPTIONS="testnet" | |||
There was a problem hiding this comment.
Fixed to use correct build arg, BUILD_TAGS should only be set by the makefile
| // init is used to include v1 upgrade testnet data | ||
| // it is also used for e2e testing | ||
| func init() { | ||
| Upgrades = []upgrades.Upgrade{v1.CreateUpgrade(v1.UpgradeDataString{ |
There was a problem hiding this comment.
only place beside tests that imports testnet and is included only if there is a testnet in build tags
|
|
||
| // init is used to include v1 upgrade for mainnet data | ||
| func init() { | ||
| Upgrades = []upgrades.Upgrade{v1.CreateUpgrade(v1.UpgradeDataString{ |
There was a problem hiding this comment.
only place beside tests that imports mainnet and is included only if there is a mainnet in build tags
Makefile sets by default this build tag
| @@ -0,0 +1,20 @@ | |||
| //go:build mainnet | |||
There was a problem hiding this comment.
I remember Go allows to build with multiple tags e.g., -tags "mainnet,testnet". Wondering what will happen in this case 🤔
There was a problem hiding this comment.
good question, in both cases I am replacing the upgrades var from app.go with a new upgrade
So, the question is which one ? 😅
One other point is that in the makefile or it includes mainnet or testnet to the build tags
Lines 82 to 87 in aea173f
app/upgrades/v1/testnetapp/upgrades/v1/mainnetmainnetortestnetthat adds the upgrade handler with the expected datamake buildcreates a binary with an upgrade plan that contains mainnet data, ifmake build-testnetis run it adds thetestnetbuild flag and adds the upgrade plan that contains testnet data