You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When checking tests for race conditions (e.g. cmd/cli/serve/serve_test.go) it highlights some race conditions in our tests with many referencing the logging library.
There appears to be an issue with how we set up logs in tests, and in particular the logging for Kubo seems to trigger it.
The zerolog issue at rs/zerolog#242 suggests that we're using it incorrectly and we should find some other way of not triggering the race conditions in tests.
The text was updated successfully, but these errors were encountered:
When checking tests for race conditions (e.g. cmd/cli/serve/serve_test.go) it highlights some race conditions in our tests with many referencing the logging library.
There appears to be an issue with how we set up logs in tests, and in particular the logging for Kubo seems to trigger it.
The zerolog issue at rs/zerolog#242 suggests that we're using it incorrectly and we should find some other way of not triggering the race conditions in tests.
The text was updated successfully, but these errors were encountered: