Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging race condition in tests #3586

Open
rossjones opened this issue Mar 11, 2024 · 0 comments
Open

Logging race condition in tests #3586

rossjones opened this issue Mar 11, 2024 · 0 comments
Labels
type/test Type: Adding or improving tests

Comments

@rossjones
Copy link
Contributor

When checking tests for race conditions (e.g. cmd/cli/serve/serve_test.go) it highlights some race conditions in our tests with many referencing the logging library.

github.com/bacalhau-project/bacalhau/pkg/logger.ConfigureTestLogging.func1()
      .../pkg/logger/logger.go:86 +0x3c

There appears to be an issue with how we set up logs in tests, and in particular the logging for Kubo seems to trigger it.

The zerolog issue at rs/zerolog#242 suggests that we're using it incorrectly and we should find some other way of not triggering the race conditions in tests.

@wdbaruni wdbaruni added the type/test Type: Adding or improving tests label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/test Type: Adding or improving tests
Projects
Status: Backlog
Development

No branches or pull requests

2 participants