Issue #6821 Fix hook_ckeditor_PLUGIN_plugin_check documentation [skip_tests] #4991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The foreach loop in the documentation was incorrect and it doesn't reflect the current structure of the array. Additionally, I think we should change $row to $group because we're looping through the groups set up in each of the toolbar rows.
|
Tugboat has finished building a preview for this pull request! Website: https://pr4991-uhsjtrpn5vc1etys3ugkrzmx6dtrklzc.tugboatqa.com/ This preview will automatically expire on the 10th of March, 2025. |
avpaderno
reviewed
Jan 10, 2025
| foreach ($format->editor_settings['toolbar']['buttons'] as $row) { | ||
| if (in_array('Underline', $row)) { | ||
| return TRUE; | ||
| $toolbars = $format->editor_settings['toolbar']; |
There was a problem hiding this comment.
The comment should be preserved, since it correctly explains what the code does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The foreach loop in the documentation was incorrect and it doesn't reflect the current structure of the array. Additionally, I think we should change $row to $group because we're looping through the groups set up in each of the toolbar rows.
Fixes Issue #6821
Fixes backdrop/backdrop-issues#6821