Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-deployments: Filter environments #2632

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Schnurbus
Copy link

Hey, I just made a Pull Request!

I've added an optional parameter to the plugin-github-deployments widget to filter for environment names. If no filter is specified, all environments are output

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@Schnurbus Schnurbus requested a review from a team as a code owner January 31, 2025 13:13
@Schnurbus Schnurbus requested a review from vinzscam January 31, 2025 13:13
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Jan 31, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-github-deployments workspaces/github-deployments/plugins/github-deployments minor v0.3.0

Signed-off-by: Pascal <pascal@schnurbus.de>
Signed-off-by: Pascal <pascal@schnurbus.de>
Signed-off-by: Pascal <pascal@schnurbus.de>
Signed-off-by: Pascal <pascal@schnurbus.de>
@Schnurbus Schnurbus force-pushed the filter-environments branch from 6f0efda to 04f0f7a Compare January 31, 2025 13:15
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙏

Signed-off-by: Pascal <pascal@schnurbus.de>
@Schnurbus
Copy link
Author

Thanks for your feedback. I've fixed your suggestions.

@Schnurbus Schnurbus requested a review from vinzscam February 7, 2025 12:56
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Feb 21, 2025
@PSchnurbus24
Copy link

Did I forget to do something?

@github-actions github-actions bot removed the stale label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants