Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/token: don't send client_id in body #71

Closed
bbigras opened this issue Jul 4, 2022 · 3 comments
Closed

/token: don't send client_id in body #71

bbigras opened this issue Jul 4, 2022 · 3 comments

Comments

@bbigras
Copy link
Contributor

bbigras commented Jul 4, 2022

see:
HeroicKatora/oxide-auth#145

basically it seems that you should only use authorization: Basic

@evert
Copy link
Collaborator

evert commented Jul 4, 2022

Hi @bbigras , I think #72 fixes this and also your other issue (#70).

If a clientSecret is passed in the constructor, we will no longer add clientId and clientSecret to the body, they are both now set in the Authorization: Basic header.

If that works for you, I will close this ticket and release a new version of this package.

@bbigras
Copy link
Contributor Author

bbigras commented Jul 4, 2022

Is there an easy way for me to use your github repo in package.json?

I tried this:

  "dependencies": {
    "@badgateway/oauth2-client": "badgateway/oauth2-client",

but I got:

Failed to resolve entry for package "@badgateway/oauth2-client". The package may have incorrect main/module/exports specified in its package.json: Failed to resolve entry for package "@badgateway/oauth2-client". The package may have incorrect main/module/exports specified in its package.json.

I think I had to run npm install and npm run prepublishOnly in node_modules/@badgateway/oauth2-client.

@bbigras
Copy link
Contributor Author

bbigras commented Jul 4, 2022

If that works for you, I will close this ticket and release a new version of this package.

It seems to work. Thanks!

@evert evert closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants