Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Suspense #34

Open
sazzer opened this issue Dec 31, 2020 · 2 comments
Open

Add support for Suspense #34

sazzer opened this issue Dec 31, 2020 · 2 comments

Comments

@sazzer
Copy link

sazzer commented Dec 31, 2020

It would be really useful if this could support the React Suspense API instead of the client needing to pay attention to the loading flag everywhere.

This would then allow for the UIs to use Suspense to put loading screens at appropriate positions in the stack, instead of forcing them to be down at the place that is actually making the API calls.

@evert
Copy link
Contributor

evert commented Dec 31, 2020

Last time I looked into this, which was a 1-2 months ago, this API did not seem ready. There's a lot of criticism on this API, and I'd say that the community hasn't quite decided yet if this is the way to go.

While conceptually I think the idea behind the feature is great, I think we need to wait for wider community adoption and for suspense to not be marked as 'experimental'.

@sazzer
Copy link
Author

sazzer commented Dec 31, 2020

One option is to do like react-query does and make it optional and disabled by default. But I fully understand the reticence to implement an experimental API 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants