Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic TOML badge no longer works with poetry.lock #10572

Closed
ReubenFrankel opened this issue Oct 1, 2024 · 3 comments
Closed

Dynamic TOML badge no longer works with poetry.lock #10572

ReubenFrankel opened this issue Oct 1, 2024 · 3 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@ReubenFrankel
Copy link
Contributor

ReubenFrankel commented Oct 1, 2024

Are you experiencing an issue with...

shields.io

🐞 Description

I've been using the dynamic TOML badge to get a package version out of a poetry.lock file. Previously, this worked fine but recently it broke with the badge displaying query not supported - as far as I can see, this comes from #10551? Is this now a restriction due to this not being a .toml file?

🔗 Link to the badge

https://img.shields.io/badge/dynamic/toml?url=https%3A%2F%2Fraw.githubusercontent.com%2FMatatika%2Ftap-spotify%2Fmaster%2Fpoetry.lock&query=package%5B%3F(%40.name%3D%3D'singer-sdk')%5D.version&label=singer-sdk

Singer SDK version

💡 Possible Solution

No response

@ReubenFrankel ReubenFrankel added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Badge tested using npm run badge https://img.shields.io/badge/dynamic/toml?url=https%3A%2F%2Fraw.githubusercontent.com%2FMatatika%2Ftap-spotify%2Fmaster%2Fpoetry.lock&query=package%5B%3F(%40.name%3D%3D'singer-sdk')%5D.version&label=singer-sdk
Output is available here

@chris48s
Copy link
Member

chris48s commented Oct 1, 2024

It isn't the input file. It is the query. For security reasons, we've now disabled script expressions in jsonpath queries.

There's more details on this in #10553 under "2. Users of Dynamic JSON/TOML/YAML badges"

@ReubenFrankel
Copy link
Contributor Author

I see, thanks. Fair enough, I will find a different solution. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

2 participants