Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in addv #1609

Closed
paulmelnikow opened this issue Mar 27, 2018 · 2 comments
Closed

Crash in addv #1609

paulmelnikow opened this issue Mar 27, 2018 · 2 comments
Assignees
Labels
bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers sentry Bugs found using Sentry

Comments

@paulmelnikow
Copy link
Member

https://sentry.io/shields/imgshieldsio/issues/503419670/

Error: Vendor hook error:,TypeError: Cannot read property 'startsWith' of undefined
    at addv (/home/m/shields/lib/text-formatters.js:71:15)
    at /home/m/shields/server.js:5652:25
    at Request.request [as _callback] (/home/m/shields/lib/request-handler.js:166:9)
    at Request.self.callback (/home/m/shields/node_modules/request/request.js:186:22)
    at Request.emit (events.js:160:13)
    at Request.<anonymous> (/home/m/shields/node_modules/request/request.js:1163:10)
    at Request.emit (events.js:160:13)
    at IncomingMessage.<anonymous> (/home/m/shields/node_modules/request/request.js:1085:12)
    at Object.onceWrapper (events.js:255:19)
    at IncomingMessage.emit (events.js:165:20)
    at endReadableNT (_stream_readable.js:1101:12)
    at process._tickCallback (internal/process/next_tick.js:152:19)
  File "/home/m/shields/lib/text-formatters.js", line 71, in addv
    if (version.startsWith('v') || ignoredVersionPatterns.test(version)) {
  File "/home/m/shields/server.js", line 5652, in null.<anonymous>
    badgeData.text[1] = versionText(version);
  File "/home/m/shields/lib/request-handler.js", line 166, in Request.request [as _callback]
    callback(err, res, body);
  File "/home/m/shields/lib/log.js", line 36, in Function.error
    Raven.captureException(msg, function (sendErr) {
  File "/home/m/shields/lib/request-handler.js", line 32, in Domain.vendorDomain.on.err
    log.error('Vendor hook error:', err.stack);
...
(14 additional frame(s) were not displayed)

Error: Vendor hook error:,TypeError: Cannot read property 'startsWith' of undefined
    at addv (/home/m/shields/lib/text-formatters.js:71:15)
    at /home/m/shields/server.js:5652:25
    at Request.request [as _callback] (/home/m/shields/lib/request-handler.js:166:9)
    at Request.self.callback (/home/m/shields/node_modules/request/request.js:186:22)
    at Request.emit (events.js:160:13)
    at Request.<anonymous> (/home/m/shields/node_modules/request/request.js:1163:10)
    at Request.emit (events.js:160:13)
    at IncomingMessage.<anonymous> (/home/m/shields/node_modules/request/request.js:1085:12)
    at Object.onceWrapper (events.js:255:19)
    at IncomingMessage.emit (events.js:165:20)
    at endReadableNT (_stream_readable.js:1101:12)
    at process._tickCallback (internal/process/next_tick.js:152:19)
@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers sentry Bugs found using Sentry labels Mar 27, 2018
@PyvesB PyvesB self-assigned this Mar 27, 2018
@PyvesB
Copy link
Member

PyvesB commented Mar 27, 2018

This is closely related to #1599. I can take care of it, but I would first like some opinions on #1615 as the fix may be very similar here. 😉

@paulmelnikow
Copy link
Member Author

Left you a review there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers sentry Bugs found using Sentry
Projects
None yet
Development

No branches or pull requests

2 participants