Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove gratipay from webpage #1966

Closed
tooomm opened this issue Aug 23, 2018 · 3 comments · Fixed by #1967
Closed

remove gratipay from webpage #1966

tooomm opened this issue Aug 23, 2018 · 3 comments · Fixed by #1967
Labels
service-badge New or updated service badge

Comments

@tooomm
Copy link
Contributor

tooomm commented Aug 23, 2018

Since the service is discontinued it's good that the badge still shows a relevant information. The webpage however doesn't need to advertise that the badge is still supported or exists at all.

At one point the code supporting that badge can get removed, but for now it should only be removed from the webpage.

Thoughts?
@PyvesB PyvesB added the service-badge New or updated service badge label Aug 23, 2018
@PyvesB
Copy link
Member

PyvesB commented Aug 23, 2018 •
edited
Loading

Yes, I think you're right here, we forgot to remove the deprecated badge from the examples. Would you like to submit a pull request? 😃

@tooomm
Copy link
Contributor Author

tooomm commented Aug 23, 2018

Sure, I'm not sure though with the recent changes to the webpage...

Is it this one?

shields/lib/all-badge-examples.js

Line 809 in ae190c5

title: 'Gratipay',

@PyvesB
Copy link
Member

PyvesB commented Aug 23, 2018

Yes, I believe so.

@tooomm tooomm mentioned this issue Aug 23, 2018
Merged
@snyk-bot snyk-bot mentioned this issue Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove gratipay from frontend tooomm/shields
2 participants
@tooomm @PyvesB