Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis-CI builds are failing, a way to solve ... #258

Closed
nitram509 opened this issue Sep 4, 2014 · 3 comments · Fixed by Woodpile37/shields#24 or Woodpile37/shields#49
Closed

Comments

@nitram509
Copy link
Contributor

Hi,

I've noticed, that the Travis-CI builds are failing, since Aug,8th.
When I've created my pull request (#256),
my build was also failing, but it wasn't my fault. Sure, everyone will say this ;-)
But, all tests are running fine on my machine.
I've googled a while and found this travis-ci/travis-ci#2654
So, it seems shields isn't alone. IMHO, the root cause is this bruce/node-temp@980b92f
Via node module 'ass' there is a dependency to 'temp-0.6.0'.
Newer version 'temp-0.8.1' fixes the problem.
To make a long story short, I've did a pull-request to module 'ass', see lloyd/ass#10
If this will accepted and released to an updated version,
shields should update its dependencies, too.
Thus, everything will shine and work again, IMHO.

Feedback and support is welcome.

Best Regards
Martin

PS: Frankly said, I just wanted to have Maven Central supported ;-) (#256)

@nitram509
Copy link
Contributor Author

UPDATE

Fixed, see: 012d08d and lloyd/ass#10

@espadrine
Copy link
Member

WOW. Thanks a lot! I'm a bit late on reading issues, so I had no idea you were the one that fixed this!

I'll focus on your PR today.

@nitram509
Copy link
Contributor Author

You're welcome.
Thanks for merging my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants