Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge Request: GitLab tags and releases #4867

Closed
svoop opened this issue Apr 4, 2020 · 4 comments · Fixed by #7021
Closed

Badge Request: GitLab tags and releases #4867

svoop opened this issue Apr 4, 2020 · 4 comments · Fixed by #7021
Labels
service-badge New or updated service badge

Comments

@svoop
Copy link

svoop commented Apr 4, 2020

Similar to GitHub badges, it would be nice to have GitLab badges for tags and releases as well. Both tags and releases are available for public repos from the GitLab API without authentication, examples:

curl -v 'https://gitlab.com/api/v4/projects/gitlab-org%2fgitlab-foss/repository/tags'
curl -v 'https://gitlab.com/api/v4/projects/gitlab-org%2fgitlab-foss/releases'

(I might have a go later this year, right now I'm a little overbooked due to COVID-19.)

@svoop svoop added the service-badge New or updated service badge label Apr 4, 2020
@svoop svoop changed the title GitLab tags and releases Badge Request: GitLab tags and releases Apr 4, 2020
@chris48s
Copy link
Member

chris48s commented Apr 4, 2020

Thanks for offering to work on this.

It has been a while since anyone looked at GitLab badges, but I think one of the issues we hit in the past was the rate limits on the API. You've noted that a token is not required to access these endpoints for public repos, but presumably there are rate limits on anonymous access?
Probably a good start would be to have a read over #541 to understand that history.

The reason we are able to provide badges for GitLab CI pipelines is because we can get the info for them without hitting their API.

@svoop
Copy link
Author

svoop commented Apr 6, 2020

@chris48s Two quick thoughts:

  • A few days ago, gitlab.com has switched to Cloudflare which could have a positive impact on rate limits. Haven't checked this though.
  • For self-hosted GitLab, possible rate limits should be ignored. Either the server admins lift them or the repo users don't used the badges. Either way, admins and users often are part of the same organisation.

@guillermin
Copy link

I've started by creating a gitlab-tag service with GitLab tag (latest by date). This is the one I'm most interested in, but I'll get around to implementing the rest of them soon.

@calebcartwright
Copy link
Member

Tag support went live earlier today, with the standard by-date/semver and pre-release filters as other similar badges. Release support should get added via #7021 in the hopefully not too distant future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants