Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-awesome #552

Closed
diomed opened this issue Oct 28, 2015 · 8 comments
Closed

font-awesome #552

diomed opened this issue Oct 28, 2015 · 8 comments
Labels
npm-package Badge generation and badge templates

Comments

@diomed
Copy link

diomed commented Oct 28, 2015

what do you think of adding Font Awesome icons to shields?
at least for custom badges (Your Badge)
& we could select, for example, font awesome icon on the left side and write text on the right one.

https://fortawesome.github.io/Font-Awesome/icons/

@espadrine
Copy link
Member

That is one fancy idea!

From their CSS, it looks like I should be able to get an SVG font (which I could hope to transform to a set of SVG files), but unfortunately, this URL is empty: https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/fonts/fontawesome-webfont.svg?v=4.4.0#fontawesomeregular.

This works, though we'd still need a script that converts it to a set of files.

@diomed
Copy link
Author

diomed commented Nov 11, 2015

so, I've asked about why that url is empty, to which I got an answer that everything is actually ok, but github actually sends a text/plain content-header, thats why it displays the source as clear text.

and if you look at the source code of that blank page, funny thing - it's all there.
so, what about that script, is that complicated to make, and do you plan to make it, maybe?

@espadrine
Copy link
Member

Good to know!

That script would download and read the full SVG font, rip out its insides, and for each glyph (which is basically a <path> anyway), it would store it in a separate SVG file, each named after the glyph. We'd put that script on a separate git project, and put all the SVG files in logo/, with all those files starting with fa-.

I'm not sure how Font-Awesome contributors work. It seems daunting to edit the SVG font by hand and convert it to ttf & cie. The main author must have his own workflow, since the contribution file states:

At the moment we are not accepting pull requests containing icons

I'd say it is between 5 and 50 hours of work, so I probably won't tackle this very soon, but you are very much encouraged to share your work if you are tackling this!

@AdrieanKhisbe AdrieanKhisbe added enhancement frontend The Docusaurus app serving the docs site labels Jan 25, 2016
@Thraka
Copy link

Thraka commented Aug 13, 2016

Would be nice to have. I wanted a custom reddit badge and I think fontawesome has a reddit icon.

@espadrine
Copy link
Member

@Thraka You can put logos in your badge as detailed in http://shields.io/#styles, through ?logo=data:image/png;base64,….

@paulmelnikow paulmelnikow added core Server, BaseService, GitHub auth, Shared helpers and removed frontend The Docusaurus app serving the docs site labels Oct 10, 2017
@tooomm
Copy link
Contributor

tooomm commented Dec 7, 2017

By the way:
Font Awesome includes icons for github, twitter, telegram, bitbucket, facebook, gitlab, gratipay, slack etc. too!

I'm only confused because there is http://fontawesome.io/ (Version 4.7.0) and https://fontawesome.com/ (Version 5.0.0) but both link to the same github...

@mabbas64
Copy link

Would be nice if support for Font Awesome 5 "Free" version is added :p So many nice icons to use from it in my forum signature badges. SimpleIcons just doesn't cut it.

@paulmelnikow paulmelnikow added npm-package Badge generation and badge templates and removed core Server, BaseService, GitHub auth, Shared helpers labels Jan 8, 2019
@paulmelnikow
Copy link
Member

Based on recent discussions, and quite a lot of time passing with some but not overwhelming support for this idea, I think we probably are not going to add this in core.

However, it's always possible to build a badge using an icon with your own SVG.

If someone wanted to build a web app that let you generate svg from a Font Awesome icon and base64-encode it, we'd be happy to link to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm-package Badge generation and badge templates
Projects
None yet
Development

No branches or pull requests

7 participants