Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated services #6514

Closed
PyvesB opened this issue May 20, 2021 · 4 comments · Fixed by #6756
Closed

Delete deprecated services #6514

PyvesB opened this issue May 20, 2021 · 4 comments · Fixed by #6756
Labels
service-badge New or updated service badge

Comments

@PyvesB
Copy link
Member

PyvesB commented May 20, 2021

We've currently got 22 deprecated service families, some of which containing more than one deprecatedService (29 of them in total). Our earliest deprecation, Gratipay, dates all the way back to 2017.

The number of deprecated services will keep growing over time if we do nothing about them. This is not an immediate problem per say, but it would be nice to tidy after ourselves and keep things under control.

Back in #1449 (comment), @paulmelnikow had suggested retaining them around for about a year before removing them for good. What do people think?

Whatever removal policy we come up with, let's document it here: https://github.com/badges/shields/blob/master/doc/deprecating-badges.md

@PyvesB PyvesB added service-badge New or updated service badge needs-discussion A consensus is needed to move forward labels May 20, 2021
@chris48s
Copy link
Member

👍 I'm on board with just binning anything we deprecated more than a year ago if you are up for doing a spring clean 🧹

@calebcartwright
Copy link
Member

Agreed. Do folks think it'd be worthwhile to have a list in a markdown file of badges that were deprecated and removed for posterity? I realize users and ourselves can always search for and look back at issues and PRs that did deprecation and removal but might be easier to have a single file somewhere we could point to

@PyvesB
Copy link
Member Author

PyvesB commented May 23, 2021

Do folks think it'd be worthwhile to have a list in a markdown file of badges that were deprecated and removed for posterity?

Whatever removal policy we come up with, let's document it here: https://github.com/badges/shields/blob/master/doc/deprecating-badges.md

We could for example have a section along the lines of Once a service is deprecated, what happens next? and list the deleted ones there.

@calebcartwright
Copy link
Member

We could for example have a section along the lines of Once a service is deprecated, what happens next? and list the deleted ones there.

Yup, I really like that idea!

@PyvesB PyvesB removed the needs-discussion A consensus is needed to move forward label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants