Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that Node 14 is installed in development #6748

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Verify that Node 14 is installed in development #6748

merged 1 commit into from
Jul 9, 2021

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Jul 9, 2021 •
edited
Loading

Avoids weird async await errors when running service tests!

Follow-on to #6652

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Jul 9, 2021
@shields-ci
Copy link

Warnings
⚠️

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against c55044e

PyvesB
PyvesB approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@paulmelnikow paulmelnikow merged commit 6d4ed3c into master Jul 9, 2021
@paulmelnikow paulmelnikow deleted the check-node-14 branch July 9, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulmelnikow @shields-ci @PyvesB @calebcartwright @shields-cd