Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logos on community page #6792

Closed
chris48s opened this issue Jul 22, 2021 · 6 comments
Closed

Fix logos on community page #6792

chris48s opened this issue Jul 22, 2021 · 6 comments
Labels
frontend The Docusaurus app serving the docs site

Comments

@chris48s
Copy link
Member

📋 Description

Heroku, NodePing and Sentry logos on https://shields.io/community are dead

@chris48s chris48s added the frontend The Docusaurus app serving the docs site label Jul 22, 2021
@Dexters-Hub
Copy link
Contributor

Hey @chris48s can I work on this?

@chris48s
Copy link
Member Author

Sure.
The correct images are in https://github.com/badges/shields/tree/master/static/images
I suspect maybe we moved a bunch of stuff around in #6651 and forgot to update a path somewhere..

@Dexters-Hub
Copy link
Contributor

Yeah got it. I will update it soon 💯

@Dexters-Hub
Copy link
Contributor

Dexters-Hub commented Jul 23, 2021

@chris48s I have corrected the path of the sponsor images. But it doesn't seems to work.

Screenshot (686)

@Dexters-Hub
Copy link
Contributor

I fixed the error by replacing the image tag to a component tag inside the file. @chris48s is this okay?

  • Added the image path
  • Replaced Image tag with Component tag
  • Made adjustments regarding the height of the SVG

Screenshot (687)

@chris48s
Copy link
Member Author

If you think you have a working solution can you submit a pull request so a maintainer can review it.
I don't think it should be necessary to turn each <img> tag into a component to fix this but this conversation will be easier if we can comment on a diff rather than trying to review a screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The Docusaurus app serving the docs site
Projects
None yet
Development

No branches or pull requests

2 participants