Supported nested groups on [GitLabPipeline] badge #7159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chris48s
reviewed
Oct 16, 2021
|
|
||
| async handle( | ||
| { project }, | ||
| { gitlab_url: baseUrl = 'https://gitlab.com', branch = 'master' } |
There was a problem hiding this comment.
GitLab now uses main as the default branch name for new repos. In #5318 we made branch a required param but added a legacy redirect to /master for existing users. Moving the route is an opportunity to update the default branch to main (but keep the master redirect on the old route). i.e: /gitlab/pipeline/gitlab-org/gitlab redirects to /gitlab/pipeline-status/gitlab-org/gitlab.svg?branch=master but if you make the URL /gitlab/pipeline-status/gitlab-org/gitlab from the frontend, that implies /gitlab/pipeline-status/gitlab-org/gitlab.svg?branch=main. How does that sound?
There was a problem hiding this comment.
Yup, works for me
chris48s
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6427