various fixes and tests for [githubpipenv] #7194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Package tests are failing with "infrastructure fail - Unexpected environment preparation error: failed to create host". I expect this is just Circle having a bit of a wobble. Will try restarting again later/tomorrow. |
| } else { | ||
| return { ref: ref.substring(1, 8) } |
There was a problem hiding this comment.
i realize now I'm even more confused by what we were doing before. any idea why we were substringing from this range before?
There was a problem hiding this comment.
Yeah sure I probably should have explained this more as there were 2 issues here:
- 1 is that we were assuming ref is always a commit hash, whereas it can be a commit hash or a tag (or a branch name actually, now I think of it)
- The other is that if it is a commit hash, we want the first 7 chars, whereas we were actually taking characters 2 though 8 which was passing the service test because we're just doing a picture check but was not actually correct.
calebcartwright
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went digging into #7188 and some worms came out of the can 🐛
This PR closes #7188 , deals with a few other edge cases and adds a bunch of unit tests for the pipenv
getDependencyVersion()helper, which did not previously have any.