Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHubIssueDetail Closed issues message color #7372

Closed
calebcartwright opened this issue Dec 12, 2021 · 4 comments · Fixed by #7374
Closed

GitHubIssueDetail Closed issues message color #7372

calebcartwright opened this issue Dec 12, 2021 · 4 comments · Fixed by #7374
Assignees
Labels
service-badge New or updated service badge

Comments

@calebcartwright
Copy link
Member

GitHub's experience tiers have switched from displaying closed issues as red to purple (e.g. see our own closed issues https://github.com/badges/shields/issues?q=is%3Aissue+is%3Aclosed), ostensibly to avoid categorically connoting the failed/rejected/etc. theme of red.

I'm wondering if we should do the same for our issue status badge (PRs will remain the same since they already differentiate between merged/rejected) and curious what others think. I confess I'm still on the fence myself, but think I'm leaning towards changing to purple

@calebcartwright calebcartwright added the needs-discussion A consensus is needed to move forward label Dec 12, 2021
@paulmelnikow
Copy link
Member

I'd lean toward changing them too.

@chris48s
Copy link
Member

yeah I reckon change it

@calebcartwright
Copy link
Member Author

Sounds like sufficient consensus to me, will take a look at implementing later today. Do we think this will be one of those things that'll need a query param for toggling between red/purple in order to satiate those preferring to maintain the red?

@chris48s
Copy link
Member

I think we can just YOLO it

@calebcartwright calebcartwright added service-badge New or updated service badge and removed needs-discussion A consensus is needed to move forward labels Dec 15, 2021
@calebcartwright calebcartwright self-assigned this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants