Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cypress.json config from custom folder #126

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

kalinchernev
Copy link
Contributor

Closes #125

Copy link
Owner

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good. Update the README file, please. Also add a test job on CircleCI to run your test command test:config (if you are not sure, let it be, I will add it)

@kalinchernev
Copy link
Contributor Author

Pushed an attempt to update the circle ci as reading https://github.com/cypress-io/circleci-orb/blob/master/docs/recipes.md#custom-test-command but i am not having enough confidence it'll work to be honest. Please feel free to commit further changes if necessary.

I also updated the readme file with the new way. Shall I follow-up that on https://github.com/bahmutov/cypress-watch-and-reload-example/blob/master/cypress/plugins/index.js too after?

@bahmutov bahmutov changed the base branch from master to custom-config-file August 16, 2021 20:19
@bahmutov
Copy link
Owner

Let me grab the code, see if it works, passes tests, and then mergee

@bahmutov bahmutov merged commit d39c73d into bahmutov:custom-config-file Aug 16, 2021
bahmutov added a commit that referenced this pull request Aug 16, 2021
* feat: allow cypress.json config from custom folder (#126)

* Allow cypress.json config from custom folder

* Revert unnecessary changes

* Attempt to circleci update

* split the test jobs

Co-authored-by: Kalin Chernev <kalinchernev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom path to config file is not respected
2 participants