Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuts issues in process #18

Closed
OJWatson opened this issue Feb 17, 2022 · 0 comments · Fixed by #19
Closed

cuts issues in process #18

OJWatson opened this issue Feb 17, 2022 · 0 comments · Fixed by #19
Assignees
@arisp99
Labels
bug unexpected problem or unintended behavior
Milestone
1.0.0

Comments

@OJWatson
Copy link
Collaborator

This line is not doing what you want it to do or the cut removal process is not quite working as you expect.

coiaf/R/process.R

Line 145 in 40b20f9

df_grouped$midpoints <- cuts[-length(cuts)] + diff(cuts) / 2

Here is a list with arguments that cause the bug

fordebug.rds.zip
@arisp99 arisp99 added the bug unexpected problem or unintended behavior label Feb 17, 2022
@arisp99 arisp99 self-assigned this Feb 17, 2022
@arisp99 arisp99 mentioned this issue Feb 17, 2022
Merged
@arisp99 arisp99 added this to the 1.0.0 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arisp99 arisp99

Labels
bug unexpected problem or unintended behavior
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Fix midpoint calculation for cuts bailey-lab/coiaf
2 participants
@OJWatson @arisp99