JOSS Review: License Conflict + Requirements File

[gchure]

Hi! I'm reviewing your project for JOSS and am opening issues as I progress through the checklist.

First, there is a conflict in licensing for PANINIpy. Your repository claims it is licensed under an MIT standard license, however your setup.py file assigns an "Unlicense" which is a legally ambiguous license (and mybe not valid in the yes of JOSS). Please converge on a license and have that unified across the project.

Second, there is no apparent requirements file for the project, leading to installation failures into a sterile venv. Please add requirements either as an external file or within the setup.py.

[baiyueh]

Hi @gchure, thanks for bringing that up, have fixed to MIT license same as the github repo. Have added both requirments.txt and include the dependencies automatically while pip install.

[gchure]

Looks good, but there are some issues with the setup.py file that made installation and running the tests problematic. I will open a new issue to discuss.