Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow fails if PHP Version is undefined #49

Closed
GlitchWitch opened this issue Dec 13, 2024 · 6 comments
Closed

Workflow fails if PHP Version is undefined #49

GlitchWitch opened this issue Dec 13, 2024 · 6 comments

Comments

@GlitchWitch
Copy link
Contributor

As of #44 it seems that the workflow now always includes the PHP version in the POST request regardless of it is set.

This causes site creation to fail if a PHP version is not defined in the workflow file, despite the variable not being required.

(This issue was originally flagged by @noahc3)

@GlitchWitch
Copy link
Contributor Author

WIP PR in #48

@GlitchWitch
Copy link
Contributor Author

It looks like manually setting the php version results in the following error;

"Resource not found."
Error: Forge API request failed with status code 404.

@bakerkretzmar
Copy link
Owner

Should be fixed in v2.7.1, thanks! Forge must have turned off the empty strings to null middleware or something because I think we've always been sending this empty string.

@GlitchWitch
Copy link
Contributor Author

Thanks @bakerkretzmar, I believe we are still running into the secondary issue I mentioned. Myself, @noahc3, and @DanielCoulbourne were unable to determine the cause of the 404 issue that presented when using branch from #48 or setting the PHP version manually.

@bakerkretzmar
Copy link
Owner

Hmm. Were you including the PHP version in the format php##, like php83? And it's a PHP version that is already installed on the server?

@noahc3
Copy link
Contributor

noahc3 commented Dec 13, 2024

Posted details in #50 to keep things organized :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants