Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate compiler warnings and turn on -Werr #776

Closed
1 of 2 tasks
ihrwein opened this issue Nov 10, 2015 · 13 comments
Closed
1 of 2 tasks

Eliminate compiler warnings and turn on -Werr #776

ihrwein opened this issue Nov 10, 2015 · 13 comments
Assignees
Labels

Comments

@ihrwein
Copy link
Contributor

ihrwein commented Nov 10, 2015

I used the master branch.

../modules/afprog/afprog.c: In function 'afprogram_reload_store_item_free':
../modules/afprog/afprog.c:69:3: warning: passing argument 1 of 'log_pipe_unref' from incompatible pointer type [enabled by default]
   log_pipe_unref(reload_info->writer);
   ^
In file included from ../lib/driver.h:29:0,
                 from ../modules/afprog/afprog.h:27,
                 from ../modules/afprog/afprog.c:24:
../lib/logpipe.h:237:6: note: expected 'struct LogPipe *' but argument is of type 'struct LogWriter *'
 void log_pipe_unref(LogPipe *self);
      ^
../modules/afprog/afprog.c: In function 'afprogram_dd_kill_child':
../modules/afprog/afprog.c:329:13: warning: unused variable 'pgid' [-Wunused-variable]
       pid_t pgid;
             ^
../modules/afprog/afprog.c: In function 'afprogram_dd_store_reload_store_item':
../modules/afprog/afprog.c:452:3: warning: passing argument 4 of 'cfg_persist_config_add' from incompatible pointer type [enabled by default]
   cfg_persist_config_add(cfg, afprogram_dd_format_persist_name(self), reload_info, afprogram_reload_store_item_destroy_notify, FALSE);
   ^
In file included from ../lib/logpipe.h:30:0,
                 from ../lib/driver.h:29,
                 from ../modules/afprog/afprog.h:27,
                 from ../modules/afprog/afprog.c:24:
../lib/cfg.h:158:6: note: expected 'GDestroyNotify' but argument is of type 'void (*)(struct AFProgramReloadStoreItem *)'
 void cfg_persist_config_add(GlobalConfig *cfg, gchar *name, gpointer value, GDestroyNotify destroy, gboolean force);

To do:

@ihrwein ihrwein added the bug label Nov 10, 2015
@ihrwein ihrwein assigned ghost Nov 10, 2015
@bazsi
Copy link
Collaborator

bazsi commented Nov 10, 2015

I saw these too, and this is pretty unfortunate as these are recent
additions.

Bazsi

On Tue, Nov 10, 2015 at 2:05 PM, Tibor Benke notifications@github.com
wrote:

../modules/afprog/afprog.c: In function 'afprogram_reload_store_item_free':
../modules/afprog/afprog.c:69:3: warning: passing argument 1 of 'log_pipe_unref' from incompatible pointer type [enabled by default]
log_pipe_unref(reload_info->writer);
^
In file included from ../lib/driver.h:29:0,
from ../modules/afprog/afprog.h:27,
from ../modules/afprog/afprog.c:24:
../lib/logpipe.h:237:6: note: expected 'struct LogPipe ' but argument is of type 'struct LogWriter *'
void log_pipe_unref(LogPipe *self);
^
../modules/afprog/afprog.c: In function 'afprogram_dd_kill_child':
../modules/afprog/afprog.c:329:13: warning: unused variable 'pgid' [-Wunused-variable]
pid_t pgid;
^
../modules/afprog/afprog.c: In function 'afprogram_dd_store_reload_store_item':
../modules/afprog/afprog.c:452:3: warning: passing argument 4 of 'cfg_persist_config_add' from incompatible pointer type [enabled by default]
cfg_persist_config_add(cfg, afprogram_dd_format_persist_name(self), reload_info, afprogram_reload_store_item_destroy_notify, FALSE);
^
In file included from ../lib/logpipe.h:30:0,
from ../lib/driver.h:29,
from ../modules/afprog/afprog.h:27,
from ../modules/afprog/afprog.c:24:
../lib/cfg.h:158:6: note: expected 'GDestroyNotify' but argument is of type 'void (
)(struct AFProgramReloadStoreItem *)'
void cfg_persist_config_add(GlobalConfig *cfg, gchar *name, gpointer value, GDestroyNotify destroy, gboolean force);


Reply to this email directly or view it on GitHub
#776.

@lbudai
Copy link
Collaborator

lbudai commented Nov 10, 2015

ehh... I think we should do something with these warnings :-(
Maybe Travis/drone.io and -Werr could help ... but we are far from that.
(or create a check-warning target in the makefile)

@bazsi
Copy link
Collaborator

bazsi commented Nov 10, 2015

I think the OSE tree is not that far, we only have a handful of warnings,
and half of them is this set. Apart from these we have 5 warnings (2 in
testcases, 2 in the sql destination, and one in the lexer).

lib/cfg-lex.c:2246:13: warning: 'yy_fatal_error' defined but not used
[-Wunused-function]
 static void yy_fatal_error (yyconst char* msg , yyscan_t yyscanner)
             ^
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afsql/afsql.c:
In function 'afsql_dd_ensure_initialized_connection':
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afsql/afsql.c:705:3:
warning: 'dbi_conn_new' is deprecated (declared at
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/install/include/dbi/dbi.h:208)
[-Wdeprecated-declarations]
   self->dbi_ctx = dbi_conn_new(self->type);
   ^
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afsql/afsql.c:
In function 'afsql_dd_init':
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afsql/afsql.c:1300:7:
warning: 'dbi_initialize' is deprecated (declared at
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/install/include/dbi/dbi.h:179)
[-Wdeprecated-declarations]
       gint rc = dbi_initialize(NULL);
       ^
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afprog/afprog.c:
In function 'afprogram_reload_store_item_free':
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afprog/afprog.c:69:18:
warning: passing argument 1 of 'log_pipe_unref' from incompatible pointer
type
   log_pipe_unref(reload_info->writer);
                  ^
In file included from
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/lib/driver.h:29:0,
                 from
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afprog/afprog.h:27,
                 from
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afprog/afprog.c:24:
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/lib/logpipe.h:237:6:
note: expected 'struct LogPipe *' but argument is of type 'struct LogWriter
*'
 void log_pipe_unref(LogPipe *self);
      ^
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afprog/afprog.c:
In function 'afprogram_dd_kill_child':
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afprog/afprog.c:329:13:
warning: unused variable 'pgid' [-Wunused-variable]
       pid_t pgid;
             ^
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afprog/afprog.c:
In function 'afprogram_dd_store_reload_store_item':
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afprog/afprog.c:452:84:
warning: passing argument 4 of 'cfg_persist_config_add' from incompatible
pointer type
   cfg_persist_config_add(cfg, afprogram_dd_format_persist_name(self),
reload_info, afprogram_reload_store_item_destroy_notify, FALSE);

^
In file included from
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/lib/logpipe.h:30:0,
                 from
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/lib/driver.h:29,
                 from
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afprog/afprog.h:27,
                 from
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/afprog/afprog.c:24:
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/lib/cfg.h:158:6:
note: expected 'GDestroyNotify' but argument is of type 'void (*)(struct
AFProgramReloadStoreItem *)'
 void cfg_persist_config_add(GlobalConfig *cfg, gchar *name, gpointer
value, GDestroyNotify destroy, gboolean force);
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/modules/kvformat/tests/test_kv_parser.c:81:1:
warning: ‘assert_kv_parser_fails’ defined but not used [-Wunused-function]
 assert_kv_parser_fails(const gchar *kv)
 ^
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/lib/tests/test_log_message.c:
In function
‘test_log_msg_set_value_indirect_with_self_referencing_handle_results_in_a_nonindirect_value’:
/home/bazsi/zwa/projects/syslog-ng-ose-3.6/source/syslog-ng/lib/tests/test_log_message.c:279:12:
warning: unused variable ‘handle’ [-Wunused-variable]
   NVHandle handle;
            ^

Bazsi

On Tue, Nov 10, 2015 at 4:28 PM, Budai Laszlo notifications@github.com
wrote:

ehh... I think we should do something with these warnings :-(
Maybe Travis/drone.io and -Werr could help ... but we are far from that.
(or create a check-warning target in the makefile)


Reply to this email directly or view it on GitHub
#776 (comment).

@lbudai
Copy link
Collaborator

lbudai commented Nov 10, 2015

Hmm... Then -Werr is a real option.

@juhaszviktor
Copy link
Contributor

+1 for the -Werr

On Tue, Nov 10, 2015 at 5:08 PM, Budai Laszlo notifications@github.com
wrote:

Hmm... Then -Werr is a real option.


Reply to this email directly or view it on GitHub
#776 (comment).

@ihrwein ihrwein changed the title compiler warnings in afprog module Eliminate compiler warnings and turn on -Werr Nov 10, 2015
@ihrwein ihrwein unassigned ghost Nov 10, 2015
@bazsi bazsi self-assigned this Nov 24, 2015
@bazsi
Copy link
Collaborator

bazsi commented Nov 24, 2015

With the last two branches, syslog-ng should compile warning free with this configuration:
Features:
Debug symbols : yes
GCC profiling : no
Memtrace : no
IPV6 support : yes
spoof-source support : yes
tcp-wrapper support : yes
Linux capability support : yes
Env wrapper support : no
systemd support : yes (unit dir: none)
systemd-journal support : system
Modules:
Module search path : ${exec_prefix}/lib/syslog-ng
Sun STREAMS support (module): no
SQL support (module) : yes
PACCT module (EXPERIMENTAL) : no
MongoDB destination (module): yes
JSON support (module) : yes
SMTP support (module) : yes
AMQP destination (module) : yes
STOMP destination (module) : yes
GEOIP support (module) : yes
Redis support (module) : no
Riemann destination (module): no
python : yes (pkg-config package: python)
java : no

I am enabling redis/riemann/java to see if they are warning free as well.

@ihrwein
Copy link
Contributor Author

ihrwein commented Dec 16, 2015

I wanted to turn this on, but I see some warnings in internal ivykis:

/bin/bash ../libtool --tag=CC   --mode=link gcc  -Werror   -o iv_event_test iv_event_test.o ../src/libivykis.la
libtool: link: gcc -Werror -o iv_event_test iv_event_test.o  ../src/.libs/libivykis.a
../src/.libs/libivykis.a(iv_main_posix.o): In function `__iv_deinit':
iv_main_posix.c:(.text+0x5a): undefined reference to `pthread_setspecific'
../src/.libs/libivykis.a(iv_main_posix.o): In function `iv_state_destructor':
iv_main_posix.c:(.text+0xaa): undefined reference to `pthread_setspecific'
../src/.libs/libivykis.a(iv_main_posix.o): In function `iv_init':
iv_main_posix.c:(.text+0xe3): undefined reference to `pthread_key_create'
iv_main_posix.c:(.text+0x134): undefined reference to `pthread_setspecific'
../src/.libs/libivykis.a(iv_thread_posix.o): In function `iv_thread_tls_deinit_thread':
iv_thread_posix.c:(.text+0x11b): undefined reference to `pthread_detach'
../src/.libs/libivykis.a(iv_thread_posix.o): In function `iv_thread_handler':
iv_thread_posix.c:(.text+0x229): undefined reference to `__pthread_register_cancel'
iv_thread_posix.c:(.text+0x250): undefined reference to `__pthread_unregister_cancel'
../src/.libs/libivykis.a(iv_thread_posix.o): In function `iv_thread_died':
iv_thread_posix.c:(.text+0x2c6): undefined reference to `pthread_join'
../src/.libs/libivykis.a(iv_thread_posix.o): In function `iv_thread_create':
iv_thread_posix.c:(.text+0x409): undefined reference to `pthread_create'
collect2: error: ld returned 1 exit status

make CFLAGS="-Werror -pthread" solves this but I don't want to add -pthread to .travis.yml.

@bkil-syslogng
Copy link
Contributor

I've checked the build log on my own computer, and make produces this
line here:

/bin/bash ../libtool --tag=CC --mode=link gcc -O0 -g -pipe -Wall -pthread -o iv_event_test iv_event_test.o ../src/libivykis.la

Could you elaborate why -pthread is missing here?

On Wed, Dec 16, 2015 at 2:10 PM, Tibor Benke notifications@github.com
wrote:

I wanted to turn this on, but I see some warnings in internal ivykis:

/bin/bash ../libtool --tag=CC --mode=link gcc -Werror -o iv_event_test iv_event_test.o ../src/libivykis.la
libtool: link: gcc -Werror -o iv_event_test iv_event_test.o ../src/.libs/libivykis.a
../src/.libs/libivykis.a(iv_main_posix.o): In function __iv_deinit': iv_main_posix.c:(.text+0x5a): undefined reference topthread_setspecific'
../src/.libs/libivykis.a(iv_main_posix.o): In function iv_state_destructor': iv_main_posix.c:(.text+0xaa): undefined reference topthread_setspecific'
../src/.libs/libivykis.a(iv_main_posix.o): In function iv_init': iv_main_posix.c:(.text+0xe3): undefined reference topthread_key_create'
iv_main_posix.c:(.text+0x134): undefined reference to pthread_setspecific' ../src/.libs/libivykis.a(iv_thread_posix.o): In functioniv_thread_tls_deinit_thread':
iv_thread_posix.c:(.text+0x11b): undefined reference to pthread_detach' ../src/.libs/libivykis.a(iv_thread_posix.o): In functioniv_thread_handler':
iv_thread_posix.c:(.text+0x229): undefined reference to __pthread_register_cancel' iv_thread_posix.c:(.text+0x250): undefined reference to__pthread_unregister_cancel'
../src/.libs/libivykis.a(iv_thread_posix.o): In function iv_thread_died': iv_thread_posix.c:(.text+0x2c6): undefined reference topthread_join'
../src/.libs/libivykis.a(iv_thread_posix.o): In function iv_thread_create': iv_thread_posix.c:(.text+0x409): undefined reference topthread_create'
collect2: error: ld returned 1 exit status

make CFLAGS="-Werror -pthread" solves this but I don't want to add
-pthread to .travis.yml.


Reply to this email directly or view it on GitHub
#776 (comment).

@bazsi
Copy link
Collaborator

bazsi commented Dec 16, 2015

I can see -pthread on that line.
On Dec 16, 2015 5:43 PM, "Tamas Nagy" notifications@github.com wrote:

I've checked the build log on my own computer, and make produces this
line here:

/bin/bash ../libtool --tag=CC --mode=link gcc -O0 -g -pipe -Wall -pthread -o iv_event_test iv_event_test.o ../src/libivykis.la

Could you elaborate why -pthread is missing here?

On Wed, Dec 16, 2015 at 2:10 PM, Tibor Benke notifications@github.com
wrote:

I wanted to turn this on, but I see some warnings in internal ivykis:

/bin/bash ../libtool --tag=CC --mode=link gcc -Werror -o iv_event_test
iv_event_test.o ../src/libivykis.la
libtool: link: gcc -Werror -o iv_event_test iv_event_test.o
../src/.libs/libivykis.a
../src/.libs/libivykis.a(iv_main_posix.o): In function __iv_deinit': iv_main_posix.c:(.text+0x5a): undefined reference to pthread_setspecific'
../src/.libs/libivykis.a(iv_main_posix.o): In function
iv_state_destructor': iv_main_posix.c:(.text+0xaa): undefined reference to pthread_setspecific'
../src/.libs/libivykis.a(iv_main_posix.o): In function iv_init': iv_main_posix.c:(.text+0xe3): undefined reference topthread_key_create'
iv_main_posix.c:(.text+0x134): undefined reference to
pthread_setspecific' ../src/.libs/libivykis.a(iv_thread_posix.o): In function iv_thread_tls_deinit_thread':
iv_thread_posix.c:(.text+0x11b): undefined reference to pthread_detach' ../src/.libs/libivykis.a(iv_thread_posix.o): In function iv_thread_handler':
iv_thread_posix.c:(.text+0x229): undefined reference to
__pthread_register_cancel' iv_thread_posix.c:(.text+0x250): undefined reference to __pthread_unregister_cancel'
../src/.libs/libivykis.a(iv_thread_posix.o): In function
iv_thread_died': iv_thread_posix.c:(.text+0x2c6): undefined reference topthread_join'
../src/.libs/libivykis.a(iv_thread_posix.o): In function
iv_thread_create': iv_thread_posix.c:(.text+0x409): undefined reference topthread_create'
collect2: error: ld returned 1 exit status

make CFLAGS="-Werror -pthread" solves this but I don't want to add
-pthread to .travis.yml.


Reply to this email directly or view it on GitHub
<#776 (comment)
.


Reply to this email directly or view it on GitHub
#776 (comment).

@bkil-syslogng
Copy link
Contributor

@bazsi: Just to elaborate, do you mean on your own computer too? Do you get
any such warnings?

On Wed, Dec 16, 2015 at 9:42 PM, Balazs Scheidler notifications@github.com
wrote:

I can see -pthread on that line.

On Dec 16, 2015 5:43 PM, "Tamas Nagy" notifications@github.com wrote:

I've checked the build log on my own computer, and make produces this
line here:

/bin/bash ../libtool --tag=CC --mode=link gcc -O0 -g -pipe -Wall -pthread -o iv_event_test iv_event_test.o ../src/libivykis.la

Could you elaborate why -pthread is missing here?

On Wed, Dec 16, 2015 at 2:10 PM, Tibor Benke notifications@github.com
wrote:

I wanted to turn this on, but I see some warnings in internal ivykis:

/bin/bash ../libtool --tag=CC --mode=link gcc -Werror -o iv_event_test
iv_event_test.o ../src/libivykis.la
libtool: link: gcc -Werror -o iv_event_test iv_event_test.o
../src/.libs/libivykis.a
../src/.libs/libivykis.a(iv_main_posix.o): In function __iv_deinit': iv_main_posix.c:(.text+0x5a): undefined reference to pthread_setspecific'
../src/.libs/libivykis.a(iv_main_posix.o): In function
iv_state_destructor': iv_main_posix.c:(.text+0xaa): undefined reference to pthread_setspecific'
../src/.libs/libivykis.a(iv_main_posix.o): In function iv_init': iv_main_posix.c:(.text+0xe3): undefined reference to pthread_key_create'
iv_main_posix.c:(.text+0x134): undefined reference to
pthread_setspecific' ../src/.libs/libivykis.a(iv_thread_posix.o): In function iv_thread_tls_deinit_thread':
iv_thread_posix.c:(.text+0x11b): undefined reference to
pthread_detach' ../src/.libs/libivykis.a(iv_thread_posix.o): In function iv_thread_handler':
iv_thread_posix.c:(.text+0x229): undefined reference to
__pthread_register_cancel' iv_thread_posix.c:(.text+0x250): undefined reference to __pthread_unregister_cancel'
../src/.libs/libivykis.a(iv_thread_posix.o): In function
iv_thread_died': iv_thread_posix.c:(.text+0x2c6): undefined reference topthread_join'
../src/.libs/libivykis.a(iv_thread_posix.o): In function
iv_thread_create': iv_thread_posix.c:(.text+0x409): undefined reference to pthread_create'
collect2: error: ld returned 1 exit status

make CFLAGS="-Werror -pthread" solves this but I don't want to add
-pthread to .travis.yml.


Reply to this email directly or view it on GitHub
<
#776 (comment)
.


Reply to this email directly or view it on GitHub
<#776 (comment)
.


Reply to this email directly or view it on GitHub
#776 (comment).

@bazsi
Copy link
Collaborator

bazsi commented Dec 18, 2015

I missed the build output as it was hidden while reading your email on my
phone. Sorry for the confusion. I don't know if I have -pthread on my box
as I don't have access to my computer right now.

On the other hand I do know that ivykis used to use weak symbols on
-lpthread to make that library optional.
On Dec 17, 2015 9:08 AM, "Tamas Nagy" notifications@github.com wrote:

@bazsi: Just to elaborate, do you mean on your own computer too? Do you get
any such warnings?

On Wed, Dec 16, 2015 at 9:42 PM, Balazs Scheidler <
notifications@github.com>
wrote:

I can see -pthread on that line.

On Dec 16, 2015 5:43 PM, "Tamas Nagy" notifications@github.com wrote:

I've checked the build log on my own computer, and make produces this
line here:

/bin/bash ../libtool --tag=CC --mode=link gcc -O0 -g -pipe -Wall -pthread -o iv_event_test iv_event_test.o ../src/libivykis.la

Could you elaborate why -pthread is missing here?

On Wed, Dec 16, 2015 at 2:10 PM, Tibor Benke <notifications@github.com

wrote:

I wanted to turn this on, but I see some warnings in internal ivykis:

/bin/bash ../libtool --tag=CC --mode=link gcc -Werror -o
iv_event_test
iv_event_test.o ../src/libivykis.la
libtool: link: gcc -Werror -o iv_event_test iv_event_test.o
../src/.libs/libivykis.a
../src/.libs/libivykis.a(iv_main_posix.o): In function __iv_deinit': iv_main_posix.c:(.text+0x5a): undefined reference to pthread_setspecific'
../src/.libs/libivykis.a(iv_main_posix.o): In function
iv_state_destructor': iv_main_posix.c:(.text+0xaa): undefined reference to pthread_setspecific'
../src/.libs/libivykis.a(iv_main_posix.o): In function iv_init': iv_main_posix.c:(.text+0xe3): undefined reference to pthread_key_create'
iv_main_posix.c:(.text+0x134): undefined reference to
pthread_setspecific' ../src/.libs/libivykis.a(iv_thread_posix.o): In function iv_thread_tls_deinit_thread':
iv_thread_posix.c:(.text+0x11b): undefined reference to
pthread_detach' ../src/.libs/libivykis.a(iv_thread_posix.o): In function iv_thread_handler':
iv_thread_posix.c:(.text+0x229): undefined reference to
__pthread_register_cancel' iv_thread_posix.c:(.text+0x250): undefined reference to __pthread_unregister_cancel'
../src/.libs/libivykis.a(iv_thread_posix.o): In function
iv_thread_died': iv_thread_posix.c:(.text+0x2c6): undefined reference to pthread_join'
../src/.libs/libivykis.a(iv_thread_posix.o): In function
iv_thread_create': iv_thread_posix.c:(.text+0x409): undefined reference to pthread_create'
collect2: error: ld returned 1 exit status

make CFLAGS="-Werror -pthread" solves this but I don't want to add
-pthread to .travis.yml.


Reply to this email directly or view it on GitHub
<
#776 (comment)
.


Reply to this email directly or view it on GitHub
<
#776 (comment)
.


Reply to this email directly or view it on GitHub
<#776 (comment)
.


Reply to this email directly or view it on GitHub
#776 (comment).

@ihrwein
Copy link
Contributor Author

ihrwein commented Dec 21, 2015

I'll send a PR and we will see what happens on Travis.

@ihrwein
Copy link
Contributor Author

ihrwein commented Dec 21, 2015

It fails: #843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants