Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elastic-v2: fixed debian packaging #1155

Merged
merged 1 commit into from
Aug 9, 2016

Conversation

lbudai
Copy link
Collaborator

@lbudai lbudai commented Aug 5, 2016

elastic-v2 is part of the mod-elastic package (plugin.conf is common
for elastic and elastic-v2 drivers).
Jest client is also added to this package.

This may be a little bit confusing, but I have my own reasons:

  • syslog-ng supports Elastisearch: not 1.7, 2.x, 5, but Elasticsearch
  • elastic and elastic-v2 exists just because the Elasticsearch Java clients
    are not compatible between 1.7.x and 2.x versions (and the bad thing
    that the package names are almost identical, but internal representation
    has been changed)
  • elastic-v2 could be packaged separately, but we have a http mode extension
    to that which is able to work with both ElasticSearch 1.x, 2.x and Elastic5

So the elastic is only for 1.7.x series, elastic-v2 could work with 2.x series
with node, transport and shield mode, and elastic-v2 http mode could work
with all versions.

References: #1118

Signed-off-by: Laszlo Budai stentor.bgyk@gmail.com

@lbudai
Copy link
Collaborator Author

lbudai commented Aug 5, 2016

Note: I haven't tried the packaging yet.
(I've just compiled it on my machine and started syslog-ng with an elasticsearch mode http config, but without elasticsearch: so I've checked only the classpath changes.)

elastic-v2 is part of the mod-elastic package (plugin.conf is common
for elastic and elastic-v2 drivers).
Jest client is also added to this package.

This may be a little bit confusing, but I have my own reasons:
 * syslog-ng supports Elastisearch: not 1.7, 2.x, 5, but Elasticsearch
 * elastic and elastic-v2 exists just because the Elasticsearch Java clients
   are not compatible between 1.7.x and 2.x versions (and the bad thing
that the package names are almost identical, but internal representation
has been changed)
 * elastic-v2 could be packaged separately, but we have a http mode extension
   to that which is able to work with both ElasticSearch 1.x, 2.x and Elastic5

So the elastic is only for 1.7.x series, elastic-v2 could work with 2.x series
with node, transport and shield mode, and elastic-v2 http mode could work
with all versions.

References: syslog-ng#1118

Signed-off-by: Laszlo Budai <stentor.bgyk@gmail.com>
@lbudai lbudai force-pushed the f/elastic-v2-mod-http-deb branch from 7354b09 to fc75e5a Compare August 7, 2016 05:54
@lbudai
Copy link
Collaborator Author

lbudai commented Aug 7, 2016

update: I've created deb packages in my local build env, then successfully installed syslog-ng (tested with elasticsearch 2.1, it worked)

@juhaszviktor
Copy link
Contributor

👍

@juhaszviktor juhaszviktor merged commit 1d5c635 into syslog-ng:master Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants