Remove fix relative path of syslog-ng in func test #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@module_path@ as exported by the configure script usually only contains the directory where modules are installed, which may contain several directories. A subsequent patch needs the directory where modules were installed by default, so publish that as well. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
As it makes the code pretty fragile and the output is generated by multiple printf() statements anyway. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
The functional test script needs these values, so make them available here. Original patch by Laszlo Meszaros, which was modified by me (Balazs Scheidler). Signed-off-by: Laszlo Meszaros <lacienator@gmail.com> Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
* From now on the syslog-ng binary doesn't have to be relative to func tests. It can be passed via SYSLOG_NG_BINARY environment variable. Signed-off-by: Laszlo Meszaros <lacienator@gmail.com> Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
|
👍 |
lbudai
added a commit
that referenced
this pull request
Jan 14, 2016
…slog-ng-in-func-test F/remove fix relative path of syslog ng in func test
MrAnno
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originallly @lmesz submitted this branch as PR #813 which I've reworked a bit. This contains a combination of his and my work and thus superseeds #813, which should be closed without merging.
The aim of this code is to make it possible to run the functest on a binary that is outside of the build tree by specifying a SYSLOG_NG_BINARY environment variable. e.g. functest would be able to run on an installed binary.
I have added @lmesz's signoff to the last patch as it was missing, but please confirm that it is ok this way (see the contributing guide what that means):
https://github.com/balabit/syslog-ng/blob/master/CONTRIBUTING.md
please merge.