Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired disputes are still showing as "pending" #722

Open
kyungmin opened this issue Dec 6, 2014 · 5 comments
Open

Expired disputes are still showing as "pending" #722

kyungmin opened this issue Dec 6, 2014 · 5 comments

Comments

@kyungmin
Copy link

kyungmin commented Dec 6, 2014

The API should update the status as "expired" when the respond_by date has passed.

https://dp.balancedpayments.com/#/marketplaces/TEST-MP7C7Ie18Da0FKtejkFB9xsC/disputes/DT4ysVRmeIb35q3GC90oWvYv

@mjallday
Copy link
Contributor

@kyungmin i don't have enough information to do this currently.

  • the Balanced API does not have the concept of expired, the state reflects what the bank has told us.
  • the dispute evidence service can tell you if the dispute has had evidence submitted but does not tell you the state of the dispute

the dashboard is the service that consumes these two bits of information and can tell you the display state of the dispute.

if you can provide more information about what an EXPIRED state means I can help you correctly model this.

@msherry
Copy link
Contributor

msherry commented Dec 10, 2014

I don't think 'expired' makes sense in this context. Disputes are either 'won', 'lost', or none of those yet, which would be 'pending'. They can go into arbitration after being won, which can either be a separate state or a movement from 'won' back to 'pending', but none of these is 'expired'.

@kyungmin
Copy link
Author

I think @msherry is right. The dispute should automatically go to lost if the respond_by date has passed.

@mjallday
Copy link
Contributor

@kyungmin the state of the dispute is not necessarily LOST until the bank tells us it is. The Balanced API does not have enough information to make this decision on its own. This is why I'm saying that the API should not be responsible for this, the dashboard should.

@kyungmin
Copy link
Author

With the latest changes in the dashboard, we are now displaying disputes as "under review" if 1) the evidence is provided or 2) it has expired. We still want to be able to filter by "pending" vs. "under review". Do you still think API is not responsible for this?

screenshot 2014-12-18 14 18 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants