Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass down sails.log config to socket.io #193

Closed
mikermcneil opened this issue Mar 2, 2013 · 1 comment
Closed

Pass down sails.log config to socket.io #193

mikermcneil opened this issue Mar 2, 2013 · 1 comment

Comments

@mikermcneil
Copy link
Member

Mainly this involves normalizing the string log levels we're using (from Winston) with the numeric log levels that socket.io accepts (which are, unfortunately, undoumented-- only fair, it's a taste of our own medicine!)

@mikermcneil
Copy link
Member Author

For reference, here's where the fix needs to be made:

https://github.com/balderdashy/sails/blob/master/lib/sails.js#L297

Should be using sails.config.log.level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants