Disabling hooks via env variables

[Mudrekh]

While trying to start our sails app in different ways, I encountered this error while trying to disable hooks (specifically grunt) by setting an environment variable.

Using 'sails_hooks__grunt=false sails lift' causes this to be thrown

error: Malformed hook! (grunt)
error: Hooks should be a function with one argument (sails)

Looking a little deeper, it seems like process.env variables are restricted to strings, but ./lib/app/private/loadHooks.js is specifically looking for Boolean literals.

[Mudrekh]

@zivc Adding a semicolon doesn't seem to do anything, running 'sails_hooks__grunt=false; sails lift --verbose' still has grunt output.

Just for extra clarification, I am running this directly using the cli by setting the environment variable in line.

[mananjadhav]

Not sure if it'll work but can you try setting it as 0?

sails_hooks__grunt=0 sails lift ?

As you rightly said process.env are defaulted as strings only.

[sgress454]

@Mudrekh alas, that's environment variables for you. I can patch this for hooks, because it'd be handy to be able to turn them off via environment configs, but there's no general fix we can make here because a) we use another module (rc) to load env vars into config, and b) there's no hard-and-fast rules about what configs can take what types.

[Mudrekh]

@Mananj That would also be passed as a string, so even if you did a truthy test on it, it wouldn't pass hook loading in loadHooks..js

@sgress454 That seems reasonable. A patch would definitely be better than nothing. I assume something simple like just adding hookPrototype === 'false' in loadHooks.js at line 22?