Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D1plo1d - Asset Changes #388

Closed
dcbartlett opened this issue May 14, 2013 · 5 comments
Closed

D1plo1d - Asset Changes #388

dcbartlett opened this issue May 14, 2013 · 5 comments

Comments

@dcbartlett
Copy link
Contributor

@D1plo1d i had to revert the changes i merged into the development branch for your asset changes. You can see it here asset-changes I've moved them into asset-changes branch. This was because the changes you implemented broke asset rack from sending assets to the front end on lift. Please check in and re-base this branch to fix the issue and i will merge back into development.

I can help some to find what caused the issue. I really would like to pull this in for you, but i can't allow it to break existing functionality. I hope you understand. I really do apologize for having to pull the code after committing it.

@D1plo1d
Copy link
Contributor

D1plo1d commented May 15, 2013

Thanks for dealing with that. I'm totally swamped with work this week, but I will take a stab at it this Sunday.

Sorry to cause you this trouble, I really should have tested it after I merged with develop. Lesson learnt.

@D1plo1d
Copy link
Contributor

D1plo1d commented May 20, 2013

I'm having trouble reproducing the problem / am not really sure where to look. What specifically is breaking for you? Could you add a test or post your stack trace?

Here are my test results: https://gist.github.com/D1plo1d/5610164

(the test results are from my rebased asset-changes branch @ https://github.com/D1plo1d/sails/tree/asset-changes )

@D1plo1d
Copy link
Contributor

D1plo1d commented May 20, 2013

Also that sails-mysql thing.. could that be obscuring the assets error for me? I haven't done any testing in node and mocha before so this is definitely new for me.

My intuition was that the mysql issue is unrelated to the assets issue. I figure I'm probably missing a dependency somewhere. Have you seen this before?

@dcbartlett
Copy link
Contributor Author

@D1plo1d it's not actually creating an error, what it isn't doing is actually compiling anything that is in assets and serving it.

sails-mysql and sails-mongo are needed to run the tests.

Let me write a test and i'll push it to the repo for you.

@mikermcneil
Copy link
Member

See #423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants