Upgrade mongodb package to v4.8 in sails-mongo

[gitcommitshow]

Node version: 12.x
DB adapter & version : sails-mongo@2.0.0

---

In order to use mongodb server v4.4 and later, we need to upgrade mongodb package version to v4.8 in sails-mongo, because current sails-mongo has mongodb package v3.5 which is not compatible with mongodb server v4.4 (as per mongodb compatibility table).

[sailsbot]

@gitcommitshow Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[gitcommitshow]

I cloned the latest sails-mongo (2.0.0) repo. Upgraded the mongodb package to v4.8.1 while running the mongodb server v4.4.13. And then ran npm test and here's the complete output alongwith the error

  normalizeDatastoreConfig
    ✓ Given a URL without a prefix, normalizeDatastoreConfig should add the prefix
    ✓ Given a URL with a comma in it (like a Mongo Atlas URL), normalizeDatastoreConfig should not modify the URL.

  aggregations
    Using `sum`
      ✓ should not throw an error if the given critieria don't match any records
    Using `avg`
      ✓ should not throw an error if the given critieria don't match any records

  dontUseObjectIds
    Without associations
      Creating a single record
        1) should create a record w/ a numeric ID


  4 passing (886ms)
  1 failing

  1) dontUseObjectIds Without associations Creating a single record should create a record w/ a numeric ID:
     Uncaught TypeError: Cannot read property 'length' of undefined
      at lib/private/machines/create-record.js:107:28
      at node_modules/mongodb/lib/utils.js:425:9
      at node_modules/mongodb/lib/operations/execute_operation.js:71:66
      at node_modules/mongodb/lib/utils.js:425:9
      at completeEndSession (node_modules/mongodb/lib/sessions.js:154:17)
      at node_modules/mongodb/lib/sessions.js:166:13
      at maybePromise (node_modules/mongodb/lib/utils.js:411:5)
      at ClientSession.endSession (node_modules/mongodb/lib/sessions.js:133:41)
      at node_modules/mongodb/lib/operations/execute_operation.js:71:36
      at node_modules/mongodb/lib/operations/insert.js:55:13
      at node_modules/mongodb/lib/cmap/connection_pool.js:299:25
      at node_modules/mongodb/lib/sdam/server.js:212:17
      at handleOperationResult (node_modules/mongodb/lib/sdam/server.js:287:20)
      at Connection.onMessage (node_modules/mongodb/lib/cmap/connection.js:219:9)
      at MessageStream.<anonymous> (node_modules/mongodb/lib/cmap/connection.js:60:60)
      at processIncomingData (node_modules/mongodb/lib/cmap/message_stream.js:132:20)
      at MessageStream._write (node_modules/mongodb/lib/cmap/message_stream.js:33:9)
      at doWrite (_stream_writable.js:403:12)
      at writeOrBuffer (_stream_writable.js:387:5)
      at MessageStream.Writable.write (_stream_writable.js:318:11)
      at Socket.ondata (_stream_readable.js:718:22)
      at addChunk (_stream_readable.js:297:12)
      at readableAddChunk (_stream_readable.js:272:9)
      at Socket.Readable.push (_stream_readable.js:213:10)
      at TCP.onStreamRead (internal/stream_base_commons.js:188:23)

Can someone help figuring this out?

[DominusKelvin]

Hey @gitcommitshow I already started work on making the migration to the latest mongodb driver/server. The error you mention is due to the fact that we are currently expecting some properties that were previously being sent when a record is created but it's no longer sent.

[DominusKelvin]

Hey @gitcommitshow, I'll be closing this issue as this PR has implemented the upgrade and it has been merged. Thank you for waiting on this 💙

Also you can check here for the upgrade information. 👇🏾

https://blog.sailscasts.com/sails-mongo-v2-1-0