Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Risk Security Issue Reported by Snyk #7358

Open
maya-jonlarracas opened this issue Nov 12, 2024 · 4 comments
Open

High Risk Security Issue Reported by Snyk #7358

maya-jonlarracas opened this issue Nov 12, 2024 · 4 comments

Comments

@maya-jonlarracas
Copy link

Node version: v20.10.0
Sails version (sails): 1.5.13
ORM hook version (sails-hook-orm): N/A
Sockets hook version (sails-hook-sockets): N/A
Organics hook version (sails-hook-organics): N/A
Grunt hook version (sails-hook-grunt): N/A
Uploads hook version (sails-hook-uploads): N/A
DB adapter & version (e.g. sails-mysql@5.55.5): N/A
Skipper adapter & version (e.g. skipper-s3@5.55.5): N/A

The dependency of sails-generate, cross-spawn 4.0.2 has a High Vulnerability in Snyk which is fixed in 7.0.5.

We are using the latest version sails 1.5.13 and detected the issue after scanning with Snyk.

Summary of the vulnerability can be found here:
https://security.snyk.io/package/npm/cross-spawn

@sailsbot
Copy link

@maya-jonlarracas Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@maya-jonlarracas maya-jonlarracas changed the title Medium risk security issue reported by Snyk High Risk Security Issue Reported by Snyk Nov 12, 2024
@maya-jonlarracas
Copy link
Author

Is cross-spawn library still being used? I noticed that it is an unused dependency.

@eashaw
Copy link
Member

eashaw commented Nov 22, 2024

@maya-jonlarracas Thanks for reporting this. We'll publish an update for sails-generate.

@eashaw eashaw added the what do you think? Community feedback requested label Nov 22, 2024
@castillo69
Copy link

its all against code of conduct and and wrongly used

@sailsbot sailsbot removed the what do you think? Community feedback requested label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants