Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing BalenaDeviceNotFound errors for devices that are offline or inacccessible for ssh #1388

Open
imrehg opened this issue Aug 7, 2019 · 2 comments

Comments

@imrehg
Copy link
Contributor

imrehg commented Aug 7, 2019

When trying to connect to a device with balena ssh, if the device is offline, or not accessible by the user, it just throws

BalenaDeviceNotFound: Device not found: <UUID>

It makes sense, when the user cannot access the device (ie. it's in someone else's app), but does not make sense when the device is just offline, and otherwise it will be accessible when it comes online. In that case IMHO it should be something like BalenaDeviceOffline error or something, so that the real reason is highlighted.

  • balena CLI version: 11.7.4
  • Operating system version: ArchLinux
  • 32/64 bit OS and processor: 64-bit
  • Install method: npm
  • If npm install, Node.js and npm version: node v11.15.0, npm 6.10.2

Please keep in mind that we try to use the issue tracker of this repository for specific bug
reports & CLI feature requests. General & troubleshooting questions are encouraged to be posted to
the balena forums, which are monitored by balena's support team and
where the community can both contribute and benefit from the answers.

Before submitting this issue please check that this issue is not a duplicate. If there is another
issue describing the same problem or feature please add your information to the existing issue's
comments.

@xginn8
Copy link
Contributor

xginn8 commented Aug 13, 2019

related to balena-io-modules/balena-errors#32

@pdcastro
Copy link
Contributor

Or at the very least, if detecting the offline condition is "difficult" or pending SDK updates, change the error message to say something like "device offline, not found or missing access permission" (so the user is aware of the uncertainty).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants