Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canonically sort diff results #82

Closed
jclerman opened this issue Sep 9, 2024 · 1 comment · Fixed by #88
Closed

canonically sort diff results #82

jclerman opened this issue Sep 9, 2024 · 1 comment · Fixed by #88

Comments

@jclerman
Copy link

jclerman commented Sep 9, 2024

Currently, the individual elements of rendered diffs do not seem to be sorted. That has impacts for robot (see ontodev/robot#1192), whose diff-results have some inconsistency (not in semantic meaning of course, but in terms of literal reproducibility).

Readability of results is also somewhat impaired, since, for example, for a class, differences in subclass axioms may appear mixed in with annotation differences, rather than in a consistent location (top of the list, say).

The code that attempts to sort results appears to be here. Not sure that it's working as intended though.

I also note that this library doesn't have a test-suite - adding one would facilitate contributions (and have the usual benefits, of course).

@balhoff
Copy link
Owner

balhoff commented Sep 16, 2024

I agree the output should be consistent. Also agree about tests. I will try to get to these changes soon, but right now not sure when that will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants