Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Improve the error reporting of XML templates when used as key values in tables #41985

Open
nipunayf opened this issue Jan 16, 2024 · 1 comment
Labels
Area/Compiler Lang/Expressions/TableConstructor Lang/Expressions/XmlTemplate Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement

Comments

@nipunayf
Copy link
Contributor

Description

The current implementation only considers and simply checks if the XML expression generates an XML element or text, returning true without considering whether the interpolated expressions are constant or not.

Describe your problem(s)

No response

Describe your solution(s)

This implementation should be improved to consider the following types of XML subtypes along with checking the expressions nested within them.

  1. xml Element
  2. xml Comment
  3. xml ProcessingInstruction
  4. xml Text
  5. xml Sequence

Related area

-> Compilation

Related issue(s) (optional)

#13944

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@nipunayf nipunayf added Type/Improvement Area/Compiler Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Lang/Expressions/XmlTemplate Lang/Expressions/TableConstructor labels Jan 16, 2024
@nipunayf
Copy link
Contributor Author

Currently, the issue is blocked by #41981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Compiler Lang/Expressions/TableConstructor Lang/Expressions/XmlTemplate Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement
Projects
None yet
Development

No branches or pull requests

1 participant